CMSSW Integration of LST #45117
CMSSW Integration of LST #45117
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45117/40456
|
|
A new Pull Request was created by @VourMa for master. It involves the following packages:
The following packages do not have a category, yet: RecoTracker/LST @cmsbuild, @rappoccio, @jfernan2, @davidlange6, @mandrenguyen, @fabiocos, @antoniovilela can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters: |
|
@cmsbuild please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 2 errors in the following unit tests: ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS ---> test testTrackingResolution had ERRORS Comparison SummarySummary:
|
both are apparently related to LST |
it's not obvious how this dependency comes about from looking at https://github.com/cms-sw/cmssw/blob/master/DQM/TrackingMonitorSource/test/testTrackResolution_cfg.py (a @makortel |
|
assign heterogeneous |
continuing migration to SoA: update LS, migrate ranges, hits, endcap, modules
…CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles
…STCore_realfiles_batch7 migrate to SoATemplate
|
This PR contains many commits (182 >= 150) and will not be processed. Please ensure you have selected the correct target branch and consider squashing unnecessary commits. |
|
batch7 (merged) includes migration to SoATemplate and PortableCollection
while that was prepared a few conflicts with CMSSW have accumulated, we'll be updating the topic branch to 14_2_0_pre3 imminently to cleanup the conflicts |
@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar Please |
Ehm, what does it mean ? |
IIUC, this is a command needed to bypass the number of commits check in the bot, which otherwise would not run any tests on a PR with more than 150 commits |
|
This PR contains many commits (183 >= 150) and will not be processed. Please ensure you have selected the correct target branch and consider squashing unnecessary commits. |
|
@cmsbuild please test |
|
+commit-count |
cmsbuild
added
tests-started
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45117/42417
|
|
Pull request #45117 was updated. @AdrianoDee, @Moanwar, @antoniovilela, @atpathak, @consuegs, @davidlange6, @fabiocos, @fwyzard, @jfernan2, @kskovpen, @makortel, @mandrenguyen, @miquork, @perrotta, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
@fwyzard , to not waste bot resources ( github api calls/commit) bot disable processing the PR if it contains over 150 commits ( this mostly happens when someone opens a PR using wrong branch). @slava77 , note that PR with over 240 commits will not be processed. For such PR one should open multiple PRs |
|
-1 Failed Tests: HeaderConsistency RelVals-INPUT
RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
GPU Comparison SummarySummary:
|
|
|
||
| namespace ALPAKA_ACCELERATOR_NAMESPACE::lst { | ||
|
|
||
| using namespace ::lst; |
There was a problem hiding this comment.
this triggers a code-rule violation
Rule1 : https://raw.githubusercontent.com/cms-sw/cmssw/master/Utilities/ReleaseScripts/python/cmsCodeRules/config.py
Search for "using namespace" or "using std::" in header files
/RecoTracker/LSTCore/interface/alpaka/Constants.h
[8]
This was suggested to be used during the review in #45117 (comment)
for RecoTracker/LSTCore/src/alpaka/Event.h
Do I understand correctly that the rule is not triggered for header files in src/?
@fwyzard
What should we do?
- leave as false-positive/acceptable
- move this expression to src/
Please advise.
There was a problem hiding this comment.
The false positive can be accepted. This line doesn't really violate any code rule (as the using namespace doesn't impact the global namespace), but haven't gotten to improve the checker yet. See also #40322.
This PR integrates the LST algorithm in CMSSW. A summary of the algorithm and its scope can be found in the recent LST presentation at the Phase 2 Software days (April 2024).
The PR includes the following additions/modifications:
The interface exposed to CMSSW.
The actual LST code.
Scripts to be used for compiling, using & testing LST outside of the full CMSSW framework.
⇒ Not relevant for CMSSW review.
⇒ Preserve ability to run in standalone.
The input & output data formats for LST.
The producers:
The configuration files needed for running LST.
Class definitions and ES producer supporting files.
test:→ Dropped in favor of a proper workflow.Scripts for local testing
Runs only the first two iterations of tracking (initialStep & highPtTripletStep).
Useful for comparisons, as LST (for now) replaces only those two tracking iterations.
Runs the LST algorithm instead of KalmanFilter for track building/seeding.
The existence of the gpu process modifier defines the hardware the algorithm runs on (CPU or GPU).There is a single change not strictly related to the above categories and a dedicated comment will be made on it.
In general, we prefer to have minimal or at most header-only dependency of LSTCore on other CMSSW packages to preserve the ability to run with standalone scripts.
This is a large PR, so we start it as an RFC with the main batch of files. In the next days, the following updates are to be expected, so that the PR can be merged:
(bot tests will probably not work currently).Goes together with cms-data/RecoTracker-LSTCore#1 (now merged).
@slava77 @ariostas
List of unresolved comments (to be updated in batches - last update: 2024/08/19):
SegmentLinking#75