Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to SoATemplate #109

Conversation

slava77
Copy link

@slava77 slava77 commented Oct 28, 2024

a combination of

for some reason the end of the target branch and the start of this topic branch did not match in commit IDs and the diffs didn't make much sense in this PR preview.
I added a merge with the realfiles cb1557e and this apparently solved the problem.

ariostas and others added 30 commits September 16, 2024 06:52
…nternally are still using the POD TrackCandidates SoA (to be migrated later)
…ed generates around 30MB of warnings with only partial TrackCandidate SoA use
migrate TrackCandidate to use SoATemplate and PortableCollection
@slava77
Copy link
Author

slava77 commented Oct 28, 2024

/run all

@slava77
Copy link
Author

slava77 commented Oct 28, 2024

I added a merge with the realfiles cb1557e and this apparently solved the problem.

I could think of an alternative to hard reset the realfiles branch back to 5f9c2f6 (the last common commit)

Copy link

There was a problem while building and running in standalone mode. The logs can be found here.

@slava77
Copy link
Author

slava77 commented Oct 28, 2024

There was a problem while building and running in standalone mode. The logs can be found here.

this is from the same u8 problem in RecoTracker/LSTCore/standalone/code/rooutil/cxxopts.h in the target branch; the topic branch is OK

Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77 slava77 merged commit 04d02b4 into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles Oct 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants