Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] add failsafes for protecting the alpaka customization against Fake HLT menus #44253

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 27, 2024

backport of #44221

PR description:

Title says it all.

PR validation:

runTheMatrix.py --what gpu -l 12434.402 runs fine in CMSSW_14_1_GPU_X_2024-02-26-2300 on the lxplus-gpu cluster.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44221

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@mmusich mmusich changed the title [14.0.X] add failsafes for protecting the alpaka customization agains Fake HLT menus [14.0.X] add failsafes for protecting the alpaka customization agains Fake HLT menus Feb 27, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu = 12434.402, 12434.403, 12434.404, 12434.412, 12450.402, 12450.403, 12450.404

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a8d3a/37777/summary.html
COMMIT: b143e07
CMSSW: CMSSW_14_0_X_2024-02-27-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44253/37777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 106394
  • DQMHistoTests: Total failures: 538
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 105856
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
  • Checked 34 log files, 39 edm output root files, 8 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 28, 2024

+hlt

  • technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich mmusich changed the title [14.0.X] add failsafes for protecting the alpaka customization agains Fake HLT menus [14.0.X] add failsafes for protecting the alpaka customization against Fake HLT menus Feb 29, 2024
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94ec3e3 into cms-sw:CMSSW_14_0_X Feb 29, 2024
14 checks passed
@mmusich mmusich deleted the mm_dev_protect_fakeMenus_in_customizeForAlpak_14_0_X branch February 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants