-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of Phase1 OMTF emulator code #43687
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38368
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38369
|
A new Pull Request was created by @mbluj for master. It involves the following packages:
@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/36792/summary.html Comparison SummarySummary:
|
Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X. |
cf023bc
to
e7de87b
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/39059
|
Pull request #43687 was updated. @epalencia, @aloeliger can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/37693/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
ping bot |
PR description:
In this PR code of OMTF L1Mu emulator is refactored and (partly) cleaned. It is needed as preparation for 2024 data-taking with an updated algorithm that enables triggering with non-pointing muons, and to decouple Phase1 (current) and Phase2 emulators.
Note: this PR does not switch on algorithm changes expected for 2024, but only prepares code for it. This will be done with other PR when new algorithm in firmware is fully validated. It will additional require an upload of new patters to DB and updated GT or (temporary) new xml files in cms-data.
PR validation:
Successfully passed matrix tests (limited)
FYI, @akalinow, @kbunkow