Refactoring of Phase1 OMTF emulator code

[mbluj]

PR description:

In this PR code of OMTF L1Mu emulator is refactored and (partly) cleaned. It is needed as preparation for 2024 data-taking with an updated algorithm that enables triggering with non-pointing muons, and to decouple Phase1 (current) and Phase2 emulators.

Note: this PR does not switch on algorithm changes expected for 2024, but only prepares code for it. This will be done with other PR when new algorithm in firmware is fully validated. It will additional require an upload of new patters to DB and updated GT or (temporary) new xml files in cms-data.

PR validation:

Successfully passed matrix tests (limited)

FYI, @akalinow, @kbunkow

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38368

• This PR adds an extra 152KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38368/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38368/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/38369

• This PR adds an extra 156KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• L1Trigger/L1TMuonOverlapPhase1 (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @thomreis, @JanFSchulte, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/36792/summary.html
COMMIT: d016cbb
CMSSW: CMSSW_14_0_X_2024-01-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43687/36792/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 150 lines to the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1280
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3245975
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43687/39059

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • L1Trigger/L1TMuonOverlapPhase1/test/expert/omtf/runMuonOverlap_Pats0x0013_efficiencyAnalyser.py:
    • Added: 0497014
    • Deleted: 728847f
  • L1Trigger/L1TMuonOverlapPhase1/test/expert/omtf/runMuonOverlap_Pats0x0013_efficiencyAnalyser_displMu.py:
    • Added: 0497014
    • Deleted: 728847f
  • L1Trigger/L1TMuonOverlapPhase1/test/expert/omtf/modifyHwToLogixLayerXml.py:
    • Added: 0497014
    • Deleted: 728847f
  • L1Trigger/L1TMuonOverlapPhase1/test/expert/omtf/runMuonOverlap_newPats_efficiencyAnalyser.py:
    • Added: 0497014
    • Deleted: 728847f

[cmsbuild]

Pull request #43687 was updated. @epalencia, @aloeliger can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/37693/summary.html
COMMIT: e7de87b
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43687/37693/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @epalencia Update UTM to 0.12.0 cmsdist#9029

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/37693/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa87dd/37693/git-merge-result

Comparison Summary

Summary:

• You potentially added 165 lines to the logs
• Reco comparison results: 63 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 1256
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244087
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TMuon#26

[antoniovilela]

+1

[antoniovilela]

ping bot