Jet phi variable in L1 correction

[theochatzis]

PR description:

Adding the phi variable for the L1 FastJet correction for JECs. This has application in introducing phi dependent JECs to address the "BPix issue" that appeared in 2023D era of data-taking and will be present in 2024. Main interest is the HLT PF jets but can apply for CHS jets offline too.

PR validation:

Tested running the latest HLT menu using this modification and applying the derived phi dependent corrections.

workflow test:
runTheMatrix.py -l 11634.0
passes

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Since the main target is the 2024 data-taking will backport in 14_0_X for use in HLT menu. It can potentially apply for re-reco in 2023D for offline jets, then would need also 13_X releases.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44084/39051

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @theochatzis for master.

It involves the following packages:

• JetMETCorrections/Algorithms (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@rappoccio, @jdamgov, @seemasharmafnal, @clelange, @jdolen, @gkasieczka, @nhanvtran, @mariadalfonso, @ahinzmann, @gouskos, @mmarionncern, @schoef this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[missirol]

@theochatzis , please open a backport to 14_0_X.

FYI: @cms-sw/hlt-l2 (not necessarily needed for the very next 14_0_X release, but relevant to future updates of online conditions, and the change looks simple)

[tvami]

@cmsbuild , please test workflow 11634.0

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2c77d/37699/summary.html
COMMIT: f7cd4f6
CMSSW: CMSSW_14_1_X_2024-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44084/37699/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 2700 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 47500
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197843
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test workflow 11634

• prev tests show diff that cannot really come from this PR

[tvami]

+1

• looking at the backport tests confirmed that the changes don't come from this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2c77d/37804/summary.html
COMMIT: f7cd4f6
CMSSW: CMSSW_14_1_X_2024-02-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44084/37804/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338753
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found