Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Jet phi variable in L1 correction #44086

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

theochatzis
Copy link
Contributor

PR description:

Backport of #44084.

PR validation:

workflow test:
runTheMatrix.py -l 11634.0
passes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @theochatzis for CMSSW_14_0_X.

It involves the following packages:

  • JetMETCorrections/Algorithms (analysis)

@tvami, @cmsbuild can you please review it and eventually sign? Thanks.
@mariadalfonso, @schoef, @seemasharmafnal, @mmarionncern, @gouskos, @clelange, @jdamgov, @ahinzmann, @gkasieczka, @rappoccio, @nhanvtran, @jdolen this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@tvami
Copy link
Contributor

tvami commented Feb 26, 2024

@cmsbuild , please test workflow 11634.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe0c74/37700/summary.html
COMMIT: f9c59b5
CMSSW: CMSSW_14_0_X_2024-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44086/37700/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tvami
Copy link
Contributor

tvami commented Feb 29, 2024

+1

  • tests look good

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

  • Merging backport before IB tests in master.

@cmsbuild cmsbuild merged commit 7d90e91 into cms-sw:CMSSW_14_0_X Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants