Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FlatPtGeneration to CloseByParticleGun #44008

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

brusale
Copy link
Contributor

@brusale brusale commented Feb 19, 2024

PR description:

This PR adds the possibilty to produce CloseBy samples that are flat in pT instead of energy. To enable this feature, FlatPtGeneration has been added. To avoid confusion, EnMax, EnMin, MaxEnSpread are replaced with VarMax, VarMin and MaxVarSpread.

In addition, the variables related to the time assignment listed in the fillDescriptions have been added to the CloseBy configs in Configuration/Generator.

PR validation:

Tested with workflow 24896.0 and private CloseBy samples production, checking the correctness of the distributions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44008/38935

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @brusale for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • IOMC/ParticleGuns (generators)

@menglu21, @cmsbuild, @bbilin, @alberto-sanchez, @GurpreetSinghChahal, @mkirsano, @SiewYan can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @grzanka, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor

@cmsbuild please test

@felicepantaleo
Copy link
Contributor

@cms-sw/generators-l2 could you please have a look to this PR?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4557b8/37576/summary.html
COMMIT: 111e116
CMSSW: CMSSW_14_1_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44008/37576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 781a4d0 into cms-sw:master Feb 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants