-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FlatPtGeneration to CloseByParticleGun #44008
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44008/38935
|
A new Pull Request was created by @brusale for master. It involves the following packages:
@menglu21, @cmsbuild, @bbilin, @alberto-sanchez, @GurpreetSinghChahal, @mkirsano, @SiewYan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
@cms-sw/generators-l2 could you please have a look to this PR? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4557b8/37576/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds the possibilty to produce CloseBy samples that are flat in pT instead of energy. To enable this feature,
FlatPtGeneration
has been added. To avoid confusion,EnMax
,EnMin
,MaxEnSpread
are replaced withVarMax
,VarMin
andMaxVarSpread
.In addition, the variables related to the time assignment listed in the
fillDescriptions
have been added to the CloseBy configs inConfiguration/Generator
.PR validation:
Tested with workflow
24896.0
and private CloseBy samples production, checking the correctness of the distributions.