Reduce complexity of erasing elements from vectors in PATTauHybridProducer [14_0_X]

[mbluj]

PR description:

This PR contains an update to PATTauHybridProducer to reduce complexity of erasing elements from vectors by using std::remove_if instead of looping over elements of the vectors. Originally proposed in #44067 (comment).
It is a technical improvement not affecting physics.

Backport of #44266 to CMSSW 14_0 series.

PR validation:

Tested in the context of original CMSSW.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 14_0 for 2024 Nano production.

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction, xpog)

@mandrenguyen, @cmsbuild, @vlimant, @jfernan2, @hqucms can you please review it and eventually sign? Thanks.
@JyothsnaKomaragiri, @gkasieczka, @gpetruc, @schoef, @mariadalfonso, @Senphy, @gouskos, @AlexDeMoor, @jdolen, @mbluj, @ahinzmann, @demuller, @Ming-Yan, @rappoccio, @andrzejnovak, @seemasharmafnal, @hatakeyamak, @AnnikaStein, @jdamgov, @mmarionncern, @azotz, @nhanvtran, @emilbols this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[vlimant]

enable nano

[vlimant]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67dab4/37876/summary.html
COMMIT: 6f6f634
CMSSW: CMSSW_14_0_X_2024-03-03-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44295/37876/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 92 lines from the logs
• Reco comparison results: 68 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338820
• DQMHistoTests: Total failures: 1358
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337440
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 36 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16430
• DQMHistoTests: Total failures: 29
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16401
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	-0.000 ( -0.0% )	5.21	5.27	-1.1%	2.147	2.232
2500.001	2.700	2.700	0.000 ( +0.0% )	4.67	4.73	-1.2%	2.559	2.646
2500.002	2.641	2.641	0.000 ( +0.0% )	4.90	4.91	-0.4%	2.563	2.642
2500.01	1.322	1.322	-0.000 ( -0.0% )	9.58	9.60	-0.2%	2.257	2.318
2500.011	1.745	1.745	0.000 ( +0.0% )	5.15	5.19	-0.9%	2.436	2.484
2500.012	1.586	1.586	0.000 ( +0.0% )	7.45	7.40	+0.6%	2.321	2.410
2500.1	2.194	2.194	0.000 ( +0.0% )	5.21	5.29	-1.5%	1.993	2.072
2500.2	2.310	2.310	0.000 ( +0.0% )	6.05	6.08	-0.4%	1.887	1.983
2500.21	1.185	1.185	0.000 ( +0.0% )	4.34	4.30	+1.0%	2.169	2.264
2500.211	1.549	1.549	0.000 ( +0.0% )	3.74	3.76	-0.7%	2.178	2.351
2500.3	2.060	2.060	0.000 ( +0.0% )	12.69	12.64	+0.4%	1.901	1.973
2500.31	1.264	1.264	0.000 ( +0.0% )	19.85	20.31	-2.3%	2.250	2.370
2500.311	1.638	1.638	0.000 ( +0.0% )	12.11	12.56	-3.5%	2.249	2.452
2500.312	7.159	7.159	0.000 ( +0.0% )	1.44	1.44	+0.1%	1.699	1.696
2500.313	1.564	1.564	0.000 ( +0.0% )	6.78	6.22	+9.1%	1.059	1.054
2500.314	1.160	1.160	0.000 ( +0.0% )	13.28	13.19	+0.7%	2.188	2.183
2500.4	2.060	2.060	0.000 ( +0.0% )	12.64	12.59	+0.4%	1.860	1.934
2500.401	1.817	1.817	0.000 ( +0.0% )	10.52	10.43	+0.9%	1.717	1.720
2500.5	19.575	19.575	0.000 ( +0.0% )	1.05	1.10	-4.5%	1.222	1.171

[vlimant]

spurious difference in nano ; what's the reason again ?

[mbluj]

spurious difference in nano ; what's the reason again ?

I think, it should not be related to this technical PR.

[vlimant]

that's not what I asked

[vlimant]

+1
we will need a renewed understanding of why the tau reconstruction is not deterministic #44309

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1