-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce complexity of erasing elements from vectors in PATTauHybridProducer [14_0_X] #44295
Reduce complexity of erasing elements from vectors in PATTauHybridProducer [14_0_X] #44295
Conversation
Erasing an element from pfChs using an iterator from pfGammas is undefined behavior. Based on the surrounding code, I guess the intention was to erase the element from pfGammas.
Erase elements of candidate vectors with remove_if instead of looping over the vectors to reduce complexity
A new Pull Request was created by @mbluj for CMSSW_14_0_X. It involves the following packages:
@mandrenguyen, @cmsbuild, @vlimant, @jfernan2, @hqucms can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67dab4/37876/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
spurious difference in nano ; what's the reason again ? |
I think, it should not be related to this technical PR. |
that's not what I asked |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR contains an update to
PATTauHybridProducer
to reduce complexity of erasing elements from vectors by usingstd::remove_if
instead of looping over elements of the vectors. Originally proposed in #44067 (comment).It is a technical improvement not affecting physics.
Backport of #44266 to CMSSW 14_0 series.
PR validation:
Tested in the context of original CMSSW.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport to 14_0 for 2024 Nano production.