Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity of erasing elements from vectors in PATTauHybridProducer [14_0_X] #44295

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Reduce complexity of erasing elements from vectors in PATTauHybridProducer [14_0_X] #44295

merged 2 commits into from
Mar 6, 2024

Commits on Feb 29, 2024

  1. Erase from correct vector in PATTauHybridProducer 

    Erasing an element from pfChs using an iterator from pfGammas is undefined behavior. Based on the surrounding code, I guess the intention was to erase the element from pfGammas.
    @makortel
    makortel committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5584911 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Reduced complexity of erasing vector elements in PATTauHybridProducer 

    Erase elements of candidate vectors with remove_if instead of looping over the vectors to reduce complexity
    @mbluj
    mbluj committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6f6f634 View commit details
    Browse the repository at this point in the history