For Cycle 9

[sqrrm]

Summary

• BSQ requested: 5660

Contributions delivered

Reviews

This month was mostly used for reviews to try to avoid PRs not stalling and making sure all developers feel their efforts are actually valued.

View all reviewed PRs

bisq-network/bisq#3749
bisq-network/bisq#3743
bisq-network/bisq#3745
bisq-network/bisq-explorer#10
bisq-network/bisq-explorer#11
bisq-network/bisq-explorer#12
bisq-network/bisq#3783
bisq-network/bisq#3772
bisq-network/bisq#3796
bisq-network/bisq#3803
bisq-network/bisq#3815
bisq-network/bisq#3819
bisq-network/bisq#3817
bisq-network/bisq#3807
bisq-network/bisq#3821
bisq-network/bisq#3823
bisq-network/bisq#3826
bisq-network/bisq#3827
bisq-network/bisq#3828
bisq-network/bisq#3850
bisq-network/bisq#3857
bisq-network/bisq#3853
bisq-network/bisq#3855
bisq-network/bisq-explorer#15
bisq-network/bisq-explorer#16
bisq-network/bisq-explorer#13
bisq-network/bisq-explorer#17
bisq-network/bisq-explorer#18
bisq-network/bisq-explorer#19
bisq-network/bisq-explorer#20
bisq-network/bisq-explorer#21
bisq-network/bisq-explorer#22
bisq-network/bisq-explorer#23
bisq-network/bisq#3858
bisq-network/bisq#3859
bisq-network/bisq#3861
bisq-network/bisq#3862
bisq-network/bisq#3870
bisq-network/bisq#3876
bisq-network/bisq-explorer#24
bisq-network/bisq#3879

BSQ requested: 2880

Explorer

Spent time with wiz on the explorer to make it more stable and on the seednode and explorer installation scripts which now work nicely. Some of the PRs reviewed are also part of this work on the explorer and installation scripts. Thanks to wiz's scripts there are now 5 explorers up and running, much more stable and distributed than the previous ones.

BSQ requested: 1580

Release testing

Performed testing according to testpad and specific testing on DAO changes that were included in the last release

BSQ requested: 750

Contributions in progress

I have put quite a bit of work into looking at some bugs but there is no conclusive results yet.

Roles performed

Bitcoin node maintainer - bisq-network/roles#66 (comment) 75
Bitcoin node operator - bisq-network/roles#67 (comment) 150
Tor relay operator - bisq-network/roles#72 (comment) 45
Explorer maintainer/operator - bisq-network/roles#11 (comment) 180
Bisq desktop maintainer - bisq-network/roles#63 (comment) 0

[ripcurlx]

You could think about collapsing the PRs reviewed with

<details>
<summary>View all reviewed PRs (TBD)</summary>
- https://github.com/bisq-network/bisq/pull/3773
- https://github.com/bisq-network/bisq/pull/3792
- https://github.com/bisq-network/bisq/pull/2315
....
</details>

to improve readability or your CR.

[sqrrm]

Cheers, that looks nincer

[chimp1984]

@sqrrm

to avoid PRs not stalling and making sure all developers feel their efforts are actually valued

I highly value your contribution but I have to add that we lost our strongest dev (@julianknutsen) because he felt that review and merge process is far from optimal (beside other reasons on the managment side). I hope we can learn from that very bad experience and avoid to lose the next top dev for such reasons.

[ripcurlx]

I think to make that possible we have to be more strict also what will be reviewed and what won't. The case with @julianknutsen delayed review was also due to the v1.2. release pressure where the maintainer resources were also bound as developer resources. I think to make this work we need to be super strict with what PRs will be reviewed timely and which won't and we have to communicate that quite clearly so there are no wrong expectations. To make the PR management easier I'll have a look at adding codacy to the Bisq repository as well. To get at least mark all those PRs that are not applying our PR requirements without having to look at them in person.

[sqrrm]

@chimp1984 indeed, I didn't review his PRs for example, and that is my main reason for prioritizing PR reviews now. We're trying to learn from that experience and this is one step. The other main one is to get the spending in check which I feel we're now getting on top of.

[MwithM]

Closed as accepted.