Creating altcoin offer not throwing error during previously set high security deposit #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
security deposit. Fixes bisq-network#3717
|
Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow. |
ripcurlx
approved these changes
Jan 3, 2020
ripcurlx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3717
Issue occurs condition:
create one buy offer with high security deposit. then create one altcoin offer.
Fixed this issue by re-validating and setting to default amount
if validation failed during initialization.