Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating altcoin offer not throwing error during high security deposit #3717

Closed
beingindot opened this issue Nov 29, 2019 · 2 comments · Fixed by #3807
Closed

Creating altcoin offer not throwing error during high security deposit #3717

beingindot opened this issue Nov 29, 2019 · 2 comments · Fixed by #3807
Labels

Comments

@beingindot
Copy link
Contributor

Description

creating altcoin offer with default security deposit percent not enabling 'Next step' option and not throwing any error also.

Version

1.2.4

Steps to reproduce

  1. create altcoin (eth) offer from alice
  2. fill 1 btc and let the default(50%) for security deposit.
  3. Next step button not enabling as well as no error in any input boxes

Expected behaviour

any one of error hint should be there

Actual behaviour

no error hints in this case

Screenshots

Screenshot from 2019-11-29 20-28-44

Device or machine

Ubuntu

Additional info

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 4, 2019

50% isn't the default deposit. Actually input for altcoins cannot be bigger than 20% which is why the next step is not active. The problem is here that somehow the validation logic wasn't triggered properly in the field. Do you have a way how to reproduce this in a structured way? I think it has something to do when switching trading accounts back and forth, the validation seems to be not cleared out properly for each field.

@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 4, 2019
@ripcurlx ripcurlx added the a:bug label Dec 4, 2019
@ripcurlx ripcurlx changed the title [1.2.4] creating altcoin offer not throwing error during high security deposit Creating altcoin offer not throwing error during high security deposit Dec 4, 2019
@beingindot
Copy link
Contributor Author

yes, i'll check on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants