Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 9 #460

Closed
beingindot opened this issue Jan 13, 2020 · 8 comments
Closed

For Cycle 9 #460

beingindot opened this issue Jan 13, 2020 · 8 comments

Comments

@beingindot
Copy link

beingindot commented Jan 13, 2020

Summary

Specify the total amount of BSQ you are requesting:

Cycle average 1 BSQ = 0.67 USD

  • BSQ requested: 3370 BSQ
  • DAO Transaction Id: e8e261e34aeb4d2402787bdff351fa785f6db55d8202366f675cdca7282296d0

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

Development Efforts: 2090 BSQ

First one is a feature for revolut account which accepts only phone number from supported countries. Other bugs were marked for v1.2.5 milestone.

V1.2.5 release testing: 1280 BSQ

Test report :
https://bisq.ontestpad.com/project/1/folder/f48/report

In this release testing filed bugs related to the minimum security deposit and
validation issues encountered.

Bugs Filed: https://github.com/bisq-network/bisq/issues/created_by/beingindot

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Roles performed

Provide links to your monthly report on any roles you are responsible for.

@beingindot beingindot changed the title [wip] For Cycle 9 For Cycle 9 Jan 13, 2020
@ripcurlx
Copy link
Contributor

Development Efforts: 2090 BSQ

First one is a feature for revolut account which accepts only phone number from supported countries. Other bugs were marked for v1.2.5 milestone.

Could you please split up your development efforts for each PR so it is easier to evaluate? I have the feeling it is a little bit high compared to other CR (e.g. #435)

@beingindot
Copy link
Author

@ripcurlx I have updated the split up now. Also pls let me know if it's not convincing. I'll reduce and resubmit as already submitted DAO proposal.

@chimp1984
Copy link

FYI: For any future dev efforts please follow closely the discussions about DAO management. We need to cut costs and only invest in efforts which have high priority.

@ripcurlx
Copy link
Contributor

@beingindot To be honest I find the compensation for each PR a little bit higher compared to other contributions in this cycle. If you don't mind it would be great if you could adapt the amount and re-submit it for next cycle.

@cbeams
Copy link
Contributor

cbeams commented Jan 17, 2020

I'll vote this down as well. 900 USD for PR bisq-network/bisq#3777 seems particularly high to me, especially considering the follow up @ripcurlx had to do in review. As others have mentioned, please feel free to resubmit in the next cycle (from your comment above, it sounds like you already plan to do this).

Also @beingindot, please review the following section of the contributor guidelines: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#write-well-formed-commit-messages. A quick look at the shortlog output will show you how your commit messages break Git's assumptions and make reading things difficult.

$ git shortlog --author beingindot
beingindot (7):
      Added padding for flowpane to resolve moneygram save issue.
      Added check for empty validation This commit is for github issue #3458 and #3459 check added for moneybeam and national bank transfer
      Added empty check validation for popmoney/revolut/uphold/zelle
      Include bloom filter for newer bitcoin core v0.19.0.1
      Revolut account should accept only phone number For issue #3728   Till now we used to accept email or phone number
       Now we are accepting only phone number in input though  for display we will provide backward compatibility.
      creating altcoin offer not throwing error during previously set high security deposit.
      Trade limit error message is not clear    Fixes #3712

Finally, please be consistent in denominating your contribution request line items and subtotals in USD. Currently you have a mix of USD and BSQ-denominated entries, and it makes it difficult to gauge things. Ideally, everything is accounted for in USD and then converted to BSQ on the top line of the request at the current 90-day moving average rate.

@beingindot
Copy link
Author

@ripcurlx Thanks will re submit for the next cycle.
@cbeams will follow the commit msg guidelines and USD/BSQ norms.

@MwithM
Copy link
Contributor

MwithM commented Jan 21, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Jan 21, 2020
@beingindot
Copy link
Author

Though it is accepted, will make some adjustments next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants