Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove listener before setting a new one #3796

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Remove listener before setting a new one #3796

merged 1 commit into from
Dec 16, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Dec 16, 2019 •
edited
Loading

Fixes #3731.

Experienced it nearly every time when testing #3790. After this fix I didn't saw this issue again.

Testing

Using master:

  • Create 3+ mediation cases
  • Close a single mediation entry
  • You will see another mediation entry to be deactivated as well (opacity: 0.4)

Using this PR:

  • Create 3+ mediation cases
  • Close a single mediation entry
  • Only this one entry should be deactivated

@ripcurlx
Remove listener before setting a new one
c8848e1 
This fixes update issues reported in bisq-network#3731.
@ripcurlx ripcurlx requested a review from sqrrm as a code owner December 16, 2019 14:43
sqrrm
sqrrm approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I haven't tested the case it's supposed to fix, but in isolation this PR looks correct on its own.

@sqrrm sqrrm merged commit 737a419 into bisq-network:master Dec 16, 2019
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 17, 2019
@ripcurlx ripcurlx deleted the fix-rendering-issue-of-disputes branch December 18, 2019 08:34
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.

Mediator UI shows closed state when mediation ticket isn't closed.
2 participants
@ripcurlx @sqrrm