Mediator UI shows closed state when mediation ticket isn't closed.

[julianknutsen]

Description

Mediator UI shows closed state when mediation isn't closed.

Version

c2e8806

Steps to reproduce

Working on a repro, but this is what I did...

1. Start localnet cluser
2. Have existing mediation case open
3. Run Arbitration/Support Process 0030
4. Start closing mediation tickets to move on to next test
5. Only close Bob's mediation ticket for an issue
6. See UI state that is asymmetrical (Mediator thinks all are closed, Alice sees ticket open)

Expected behaviour

Mediation ticket with required actions should show as OPEN and not be grey

Actual behaviour

Mediation ticket with required action shows CLOSED and is grey

Screenshots

Device or machine

Ubuntu 19.10

Additional info

After reboot the mediation UI is correct

alice-bisq.log
bob-bisq.log
mediator-bisq.log

[chimp1984]

The filtering of the list by the "open" predicate is not applied after closing a ticket but only at view activation (switch views or restart). It would require to refresh the list with the filter predicate after the close action.

[julianknutsen]

It is more than just a filtering issue. Trade 67144 is in state Closed in the mediation UI, but OPEN on Alice.

[chimp1984]

Oh... Does Alice have received the close message?

[ripcurlx]

So it seems the dispute result message for Alice wasn't sent out or failed somehow else.

bisq/desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java

Lines 671 to 688 in 037f167

	private void doClose(Button closeTicketButton) {
	disputeResult.setLoserPublisher(isLoserPublisherCheckBox.isSelected());
	disputeResult.setCloseDate(new Date());
	dispute.setDisputeResult(disputeResult);
	dispute.setIsClosed(true);
	String text = Res.get("disputeSummaryWindow.close.msg",
	DisplayUtils.formatDateTime(disputeResult.getCloseDate()),
	formatter.formatCoinWithCode(disputeResult.getBuyerPayoutAmount()),
	formatter.formatCoinWithCode(disputeResult.getSellerPayoutAmount()),
	disputeResult.summaryNotesProperty().get());
	if (dispute.getSupportType() == SupportType.MEDIATION) {
	text += Res.get("disputeSummaryWindow.close.nextStepsForMediation");
	} else if (dispute.getSupportType() == SupportType.REFUND) {
	text += Res.get("disputeSummaryWindow.close.nextStepsForRefundAgentArbitration");
	}
	checkNotNull(getDisputeManager(dispute)).sendDisputeResultMessage(disputeResult, dispute, text);

As the closed state is set before sending the message it could be that the mediation case is closed, but the message isn't delivered (we properly should move the setting of the closed state only if onArrived or onStoredInMailbox was successful). What I don't get is that the mediation case is open again after a restart. It should be already queued up to be saved and I don't see any code part that could reset the property. It looks like storage of the dispute failed?

For the failed sending part: Did you see the ...arrived at peer... log statement in the mediator for Alice`s dispute closed message? Or do you see a ...failed: ...?

[julianknutsen]

So, after a restart the Mediator sees the state as OPEN which is what I would have expected. I only closed Bob's ticket so it is probably a UI bug somewhere where it marked both rows as CLOSED even though only Alice's should have been CLOSED.

I've updated the description to make it more clear what actions I took.

[chimp1984]

I only closed Bob's ticket so it is probably a UI bug

Yes I think there are some list item update bugs.

[ripcurlx]

Yes, maybe it is some list item caching bug, so that the opacity property is not cleared properly.