Fix style issues #3876
Merged
Fix style issues #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind putting the before and after screenshot of what's changed? |
|
Added another fix for the small label icon in dark mode Before |
wiz
previously approved these changes
Jan 8, 2020
|
|
|
I had to add back a manual workaround as it wasn't possible to solve it otherwise 😞 |
RiccardoMasutti
approved these changes
Jan 8, 2020
| cssThemeFolder + "bisq.css", | ||
| cssThemeFolder + "images.css", | ||
| cssThemeFolder + "CandleStickChart.css", | ||
| // load base styles first |
There was a problem hiding this comment.
It was badly indented before, should be 8 for arguments.
There was a problem hiding this comment.
sorry this was one of my early contributions and I had my text editor set to hard tabs or something
sqrrm
approved these changes
Jan 8, 2020
| cssThemeFolder + "bisq.css", | ||
| cssThemeFolder + "images.css", | ||
| cssThemeFolder + "CandleStickChart.css", | ||
| // load base styles first |
There was a problem hiding this comment.
It was badly indented before, should be 8 for arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a text style issue in the offer book that occurs every now and then depending on the other cell row text colors.
Before
After
Also it moves all color codes to the top in the dark mode to be more consistent.