Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate wallet date when restoring from seed #3749

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Validate wallet date when restoring from seed #3749

merged 1 commit into from
Dec 6, 2019

Conversation

devinbileck
Copy link
Member

Prevent a date that is older than the oldest wallet date, or a date that
is newer than the current date.

@devinbileck
Validate wallet date when restoring from seed
d1932fe 
Prevent a date that is older than the oldest wallet date, or a date that
is newer than the current date.
sqrrm
sqrrm approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 87fb9c0 into bisq-network:master Dec 6, 2019
@devinbileck devinbileck deleted the restore-from-seed branch December 6, 2019 17:59
chimp1984
chimp1984 reviewed Dec 6, 2019
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the oldest date I think we should use the latest v0.5 release date as that is when we changed wallet format.

@devinbileck
Copy link
Member Author

Though it may not be desired, I believe it is technically possible to restore prior to that. I figured it would be best to give the user the possibility to do that.
Perhaps it makes sense to implement feedback within the UI to inform/ask the user when they attempt to restore without specifying a date. At a minimum, inform them what happens when they dont specify a date, and inform them that any current Bisq wallet does not date older than the v0.5 release date.

@devinbileck devinbileck mentioned this pull request Dec 9, 2019
Closed
@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 10, 2019
@devinbileck devinbileck mentioned this pull request Dec 13, 2019
Closed
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 left review comments

@sqrrm sqrrm sqrrm approved these changes

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
in:gui in:wallet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@devinbileck @sqrrm @chimp1984 @ripcurlx