Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide feedback when attempting to restore a wallet from seed words without specifying a date #3766

Closed
devinbileck opened this issue Dec 9, 2019 · 2 comments · Fixed by #4283
Closed

Provide feedback when attempting to restore a wallet from seed words without specifying a date #3766

devinbileck opened this issue Dec 9, 2019 · 2 comments · Fixed by #4283
Labels
a:bug in:gui is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation

Comments

@devinbileck
Copy link
Member

Add feedback within the UI to inform/ask the user when they attempt to restore a wallet from seed words without specifying a date. At a minimum, inform them what happens when they dont specify a date, and inform them that any current Bisq wallet does not date older than the v0.5 release date.

This is in reponse to feedback received to #3749.
@ripcurlx ripcurlx added is:priority PR or issue marked with this label is up for compensation is:critical https://bisq.wiki/Critical_bug labels Feb 18, 2020
@cbeams cbeams added the a:bug label Feb 27, 2020
@ghost
Copy link

ghost commented Jun 4, 2020

@devinbileck does this look appropriate?

image

As you have not specified a wallet date, bisq will have to scan the blockchain from 2013.10.09 (the BIP39 epoch date).

BIP39 wallets were first introduced in bisq on 2017.06.28 (release v0.5). So you could save time by using that date.

Ideally you should specify the date your wallet seed was created.

Are you sure you want to go ahead without specifying a wallet date?

@ghost ghost mentioned this issue Jun 4, 2020
Merged
@devinbileck
Copy link
Member Author

@jmacxx looks good to me.

eigentsmis pushed a commit to eigentsmis/bisq that referenced this issue Jun 26, 2020
@eigentsmis
Warning when restoring wallet seedwords without date
b393874 
When the user restores a BIP39 wallet from seed words there is
an optional 'wallet date' field.  If the user does not enter that
field the chain scan will be a lengthy process.
Issue a popup message to the user in this case, informing them
that the synch will take a long time and can be reduced by either
specifying the wallet creation date or the date when Bisq introduced
BIP39 seed words.

Fixes bisq-network#3766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:gui is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn when restoring wallet seedwords without date
3 participants
@ripcurlx @cbeams @devinbileck