Use min. refund at mediated payout #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At mediation we require a min. payout to the losing party to keep incentive for the trader to accept the mediated payout. For Refund agent cases we do not have that restriction.
|
Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow. |
sqrrm
requested changes
Jan 2, 2020
desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java
Outdated
Show resolved
Hide resolved
ripcurlx
approved these changes
Jan 3, 2020
|
@sqrrm Could you please review the changes by @chimp1984 so I'm able to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At mediation we require a min. payout to the losing party to keep
incentive for the trader to accept the mediated payout. For Refund
agent cases we do not have that restriction.
There is a change in the adjustment behaviour for custom payout. The previous adjustment at keystroken does not work anymore as when one enters 0.1 the first 0 key stroke would trigger already the min refund value. I changed the event type to focus out, so the adjustment is only done at focus out. Clicking on the background does not trigger a focus out, only if you click on a control (text field, button, toggle,...).
I also added a check to not allow that both outputs are 0 at refund agent case. That was previously possible but caused an exception in the wallet class. Not the button will stay deactivated if both are 0 BTC.
Testing:
Run test case with mediation and refund agent and toggle between the 4 predefined payout distributions as well as a custom payout. Use diff. values including 0, negative and too high to see if it auto-adjusts after focus out. Note that mediation and refund agent have differnet policy here.