Display minimum limit if used during trade

[ripcurlx]

In the past we didn't give the user a hint if the minimum trading fee or minimum deposit was used.
It was shown to the user during offer creation and gave especially new users the impression
that Bisq has very high trading fees and requires a crazy amount for deposit in relation to the trading amount.

Fixes #3868, #3746.

Before

After


I've added an additional label when a minimum value (deposit or trading fee) is used.


Additionally if the trade amount is so low that the minimum security deposit for the buyer will be used I deactivated the option to set a specific percentage (which just wasn't used in the past in that case) and displayed the BTC value.

If the amount is high enough so that the minimum amount doesn't need to be used the behavior is as it is right now.

[ripcurlx]

@m52go Could you go over my wording?

I'm aware that this is quite a change if we merge it into the v1.2.5 release branch afterwards, but as with #3826 this will occur in more cases especially for new users. So IMO I think we should add this to the v1.2.5 release branch.

@sqrrm @chimp1984 What do you think?

[ripcurlx]

Just found a small bug - will push the fix soon.

[m52go]

Ideally percentages shouldn't show for minimum values...even with clarification, 6000% security deposit will raise eyebrows.

If it's not too much work to implement, this would be best for such cases:

Your security deposit: 0.0060 BTC (required minimum)

Otherwise I recommend this (existing text is too specific, I think):

guiUtil.minValue=required minimum

So that it reads:

Your security deposit: 0.0060 BTC (6000.00% of trade amount) - required minimum

[ripcurlx]

Ideally percentages shouldn't show for minimum values...even with clarification, 6000% security deposit will raise eyebrows.

If it's not too much work to implement, this would be best for such cases:

Your security deposit: 0.0060 BTC (required minimum)

Otherwise I recommend this (existing text is too specific, I think):

guiUtil.minValue=required minimum

So that it reads:

Your security deposit: 0.0060 BTC (6000.00% of trade amount) - required minimum

Good point - I'll adapt the code.

[sqrrm]

Concept ACK

Not sure about including in 1.2.5

[ripcurlx]

@m52go way better now (and less code and translations changes)

[ripcurlx]

Concept ACK

Not sure about including in 1.2.5

Yes, it changes some stuff in the trading process. But as only @beingindot has done some trade process release testing yet, we don't loose lots of testing confidence. Maybe if I and someone else runs the trade process again we should be on the safe side.

[sqrrm]

utACK

[sqrrm]

I think you're right, let's include this in the release.