Increase security deposits #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to bisq-network/proposals#155 For buyer: Default: 15% Min. 15% for Altcoin, 15% for Fiat Max. 50% for Altcoin, 50% for Fiat Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD) For Seller: Fixed: 15% Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)
|
Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow. |
sqrrm
approved these changes
Jan 2, 2020
|
During testing it might be worth taking care to test that the different verifiers don't work against each other to cause impossible conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement adjustment according to: bisq-network/proposals#155
For buyer:
Default: 15%
Min. 15% for Altcoin, 15% for Fiat
Max. 50% for Altcoin, 50% for Fiat
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)
For Seller:
Fixed: 15%
Absolute min. deposit in BTC: 0.006 BTC (currently 40 USD)
Testing:
Create all offer types with min. sec. deposit, max. sec. deposit, min. trade amount, max. trade amount for both buy and sell side and fiat and altcoins. Take all offers and exectute trade if all works.
Also test backward compatibility with one node on PR version and one on master with all above combinations.