Speed up trades charts view load #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are mostly injected objects that are now redundant, such as some CoinFormatter and Preferences fields. Also do some additional minor tidying of TradesChartsViewModel.
Use a LinkedHashMap in place of a List, for the caching CurrencyUtil fields 'allSortedFiatCurrencies' & 'allSortedCryptoCurrencies', using the same iteration order as before. In this way, we can avoid a linear search in the lookup methods getFiatCurrency & getCryptoCurrency. In particular, this speeds up the activation of TradesChartsView (and to a lesser extent OfferBookChartView), which make a lot of calls to CurrencyUtil.getTradeCurrency in the fillTradeCurrencies/updateChartData methods respectively.
|
Just a heads up that I haven't planed to be available until 2nd of Jan, but I'll still try to do some reviews tomorrow. |
sqrrm
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
LinkedHashMapin place of aList, for the cachingCurrencyUtilfieldsallSortedFiatCurrencies&allSortedCryptoCurrencies, using the same iteration order as before. In this way, we can avoid a linear search in the lookup methodsgetFiatCurrency&getCryptoCurrency.In particular, this speeds up the activation of
TradesChartsView(and to a lesser extentOfferBookChartView), which make a lot of calls toCurrencyUtil.getTradeCurrencyin thefillTradeCurrencies/updateChartDatamethods respectively.Additionally, do some tiding of
TradeChartsViewModeland remove some unused constructor-injected fields from that class and others.To reproduce the hotspot, one can select the Trades tab under Market at least once, then flipping repeatedly between (say) the Market and Buy BTC panels, the following hotspots are revealed by JProfiler:
(The also very significant
com.sun.javafx.collections.VetoableListDecorator.setAllhotspot seen at the bottom of the screenshot occurs during the initialisation of many views, but I haven't been able to find the cause or a fix for that yet.)