Promote modules iam_role and iam_role_info #1758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
rds_instance - add deletion_protection param Depends-On: ansible-collections#1116 SUMMARY Fixes ansible-collections#922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None>
) route53: add support for GeoLocation parameter SUMMARY Added support for GeoLocation parameter to community.aws.route53 Fixes ansible-collections#89. ISSUE TYPE Feature Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Uses https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Sloane Hertel <None> Reviewed-by: Alina Buzachis <None>
…collections#1110) * ec2_transit_gateway_IncorrectState: retry on IncorrectState Do not immediately bail out in case of IncorrectState error. We now instead wait and retry. E.g: https://ddf1d621d7b816539203-e56a3e9170eb32404c2ff3e77b13356f.ssl.cf2.rackcdn.com/799/690df9c2d3f69323837542b96fa7318650fd5308/check/integration-community.aws-1/f30fb4f/job-output.txt
aws_kms - minor doc fixes SUMMARY Minor doc fixes ISSUE TYPE Docs Pull Request COMPONENT NAME aws_kms aws_kms_info Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
aws_secret - Support purge_tags
SUMMARY
aws_secret currently defaults to purging all tags (even if tags isn't specified), this is a little aggressive.
Add purge_tags parameter
Only purge tags if tags: {} is set (rather than when tags is None
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
Related to ansible-collections#1146
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
New Modules : NetworkFirewall firewall SUMMARY New modules for managing the NetworkFirewall firewall resources. ISSUE TYPE New Module Pull Request COMPONENT NAME networkfirewall networkfirewall_info ADDITIONAL INFORMATION TODO: Finish up documentation (usage examples) Integration tests Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None>
fix ecs_cluster integration test SUMMARY ecs_cluster: make ecs_cluster integration test work again - as it is bugs I've hit and must be fixed to complete this challenge ecs_taskdefinition: fix change detection of changing launch_type parameter ecs_service: compare of task_definition never works and results always in a changed task change detect of health_check_grace_period_seconds was never implemented, but tested and failing, after the task_definition is compared correctly ref: ansible-collections#1142 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ecs_service ADDITIONAL INFORMATION basically the existing test tasks are not changed. just sorted and removed what was marked as fixme because it's simple not possible (changing network settings of a created service). Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]>
…le-collections#1081) rds_instance - add snapshot tests, update docs, refactor tests Depends-On: ansible-collections#776 Depends-On: ansible-collections#1105 SUMMARY add snapshot tests to test restoring db from snapshot and fix bugs associated fix some typos in documentation and remove duplicate parameter (added as alias so no breaking change) remove unused IAM role in tests and add some missing cleanups ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION this module had both db_snapshot_identifier and snapshot_identifier as separate params, with the latter being required to restore from snapshot, resulting in some parameter missing errors. moving snapshot_identifier as an alias of db_snapshot_identifier fixes this issue. Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Sloane Hertel <None>
…ections#1078) rds_instance_snapshot - add copy snapshot functionality Depends-On: ansible-collections#776 Depends-On: ansible-collections#1116 SUMMARY Add support for copying a snapshot Fixes ansible-collections#210 Don't require db_instance_identifier on state = present (only required for creation) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None>
…llections#1158) ec2_lc - remove unused associate_public_ip_address option SUMMARY The associate_public_ip_address option has always been ignored by ec2_lc, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_lc ADDITIONAL INFORMATION See also: ansible/ansible#64230 Reviewed-by: Alina Buzachis <None>
ec2_eip - remove wait_timeout SUMMARY Remove the wait_timeout option, it has always been ignored by the module ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ADDITIONAL INFORMATION See also: ansible/ansible#64230 Reviewed-by: Markus Bergholz <[email protected]>
…ections#1165) s3_lifecycle - drop deprecated requester_pays parameter SUMMARY The requester_pays did nothing, drop it. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See also: ansible/ansible#63989 Reviewed-by: Markus Bergholz <[email protected]>
s3_sync - drop unused retries parameter SUMMARY The retries parameter was never used, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_sync ADDITIONAL INFORMATION See also: ansible/ansible#63989 Reviewed-by: Markus Bergholz <[email protected]>
…#1161) ecs_ecr - remove deprecated delete_policy option SUMMARY Remove the deprecated delete_policy option. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION See also: ansible/ansible#48997 Reviewed-by: Markus Bergholz <[email protected]>
…ible-collections#1167) elb_network_lb - change default state from 'absent' to 'present' SUMMARY change default state from 'absent' to 'present' to match our usual behaviour. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_network_lb ADDITIONAL INFORMATION See also: ansible/ansible#65468 Reviewed-by: Markus Bergholz <[email protected]>
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]>
…s#1162) Fix issue when creating GSI with global_keys_only SUMMARY fixes: ansible-collections#967 Undocumented requirement on NonKeyAttributes that it should be omitted rather than an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1 fatal: [localhost]: FAILED! => {"boto3_version": "1.18.47", "botocore_version": "1.21.47", "changed": false, "msg": "Failed to update table: Parameter validation failed:\nInvalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1"} Reviewed-by: Markus Bergholz <[email protected]>
data_pipeline - remove unused version option SUMMARY The version option has always been ignored and has now been removed. ISSUE TYPE Feature Pull Request COMPONENT NAME data_pipeline ADDITIONAL INFORMATION See also: ansible/ansible#64368 Reviewed-by: Markus Bergholz <[email protected]>
…sible-collections#1164) ec2_metric_alarm - drop deprecated support for symbolic operators SUMMARY With the migration to boto3 symbolic operators were deprecated. Remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metric_alarm ADDITIONAL INFORMATION See also: ansible/ansible#62669 Reviewed-by: Markus Bergholz <[email protected]>
…ions#1172) aws_kms_info - remove deprecated keys_attr parameter SUMMARY remove deprecated keys_attr parameter ISSUE TYPE Feature Pull Request COMPONENT NAME aws_kms_info ADDITIONAL INFORMATION See also: ansible-collections#838 Reviewed-by: Alina Buzachis <None>
elb_instance - remove ec2_elbs fact SUMMARY The ec2_elbs fact was deprecated when we migrated to boto3, remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See also: ansible-collections#773 Reviewed-by: Alina Buzachis <None>
…ections#1170) ecs_service - fix validation for `placementConstraints` SUMMARY Fixes ansible-collections#1058 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Oleksandr Novak <[email protected]> Reviewed-by: Alina Buzachis <None>
…ansible-collections#1186) Tagging - remove default empty dict where purge_tags default is False Depends-On: ansible-collections#844 SUMMARY Deprecate purge_tags=False Remove default of empty dict for tags ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_kms.py plugins/modules/cloudfront_distribution.py plugins/modules/ec2_vpc_vpn.py plugins/modules/rds_param_group.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
…collections#1152) lambda_info - refactor to fix bug when querying all lambdas Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes ansible-collections#1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…tions#1184) ecs_tag/efs_tag - add resource_tags as alias for tags SUMMARY Cleanup related to the tagging fragment ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_tag efs_tag ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
…ctions#1877) Add transit-gateway-id parameter to ec2_vpc_vpn module SUMMARY This PR adds transit_gateway_id parameter to ec2_vpc_vpn module. It is needed for the validated content role that manages the creation of transit gateway and attaches VPN to the created transit gateway. ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell
api_gateway - add parameter name SUMMARY api_gateway - Add parameter name to defined the name of the API gateway to create/update, default to ansible-temp-api for backward compatibility ISSUE TYPE Feature Pull Request COMPONENT NAME api_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell
…ollections#1921) Mass update of docs and tests (credentials/session tokens) SUMMARY We had a cleanup of credentials/session parameters which included a batch of deprecations and renames. Ensure that all of our tests and docs are using the 'canonical' names ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/cloudformation_exports_info.py plugins/modules/ec2_vpc_vpn.py plugins/modules/elasticache.py plugins/modules/elasticache_parameter_group.py plugins/modules/elasticache_snapshot.py plugins/modules/ses_rule_set.py plugins/modules/sts_assume_role.py plugins/modules/sts_session_token.py tests/integration ADDITIONAL INFORMATION See also ansible-collections#1172 ansible-collections#1714 Reviewed-by: Alina Buzachis
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
Fix version_added for route53_wait SUMMARY We accidentally set version_added to 6.2 instead of 6.3 ISSUE TYPE Docs Pull Request COMPONENT NAME route53_wait ADDITIONAL INFORMATION
…-collections#1892) feat: adds platform config to task definition to support ARM SUMMARY Fixes ansible-collections#1891 ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_taskdefinition ADDITIONAL INFORMATION I've just added the Parameter the same way the other parameters are also included. Tested it with our AWS Account. Reviewed-by: Alina Buzachis Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Thomas Bruckmann
Cleanup after renamed plugins SUMMARY Prior to 5.0.0 we renamed various modules. Cleanup the integration tests (and some docs). ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/acm_certificate.py plugins/modules/acm_certificate_info.py plugins/modules/autoscaling_policy.py plugins/modules/codepipeline.py plugins/modules/storagegateway_info.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…and minor code refactoring
abikouo
force-pushed
the
move_iam_role_modules_from_community
branch
from
4d2ceb9 to
1b1acfc
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 11s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 11s |
tremble
requested changes
Sep 19, 2023
|
682 Commits? Something looks like it's gone very wonky here... |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 14s |
changelogs/fragments/20230915_migrate_iam_role_and_iam_role_info.yml
Outdated
Show resolved
Hide resolved
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 02s |
The git history is not good, I am closing this in favor of #1760 |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…#1759) Merge in 5.4.0 changelogs SUMMARY Follow up on ansible-collections#1758 ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate modules iam_role and iam_role_info from community.aws
Apply deprecations:
ISSUE TYPE
COMPONENT NAME
iam_role
iam_role_info