-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unsafe conditionals in integration tests #1891
Avoid unsafe conditionals in integration tests #1891
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
- "'engine_mode' in _result_tag_db_cluster" | ||
- _result_tag_db_cluster.engine_mode == "provisioned" | ||
- "'engine_version' in _result_tag_db_cluster" | ||
- "'master_username' in _result_tag_db_cluster" | ||
- _result_tag_db_cluster.master_username == "{{ username }}" | ||
- _result_tag_db_cluster.master_username == username | ||
- "'port' in _result_tag_db_cluster" | ||
- _result_tag_db_cluster.port == {{ port }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this kind of assertion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still digging into failures...
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/elb_classic_lb/tasks/https_listeners.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ec2_instance_metadata_options/tasks/main.yml
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
1b67b18
to
46d08d3
Compare
Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866
Co-authored-by: Bikouo Aubin <[email protected]>
…e're expecting (and it has the things we're testing for)
recheck |
recheck |
dc08059
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1903 🤖 @patchback |
Avoid unsafe conditionals in integration tests SUMMARY Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow. Affected tasks identified with: https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests ADDITIONAL INFORMATION There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit dc08059)
[PR #1891/dc080593 backport][stable-7] Avoid unsafe conditionals in integration tests This is a backport of PR #1891 as merged into main (dc08059). SUMMARY Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow. Affected tasks identified with: https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests ADDITIONAL INFORMATION There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally Reviewed-by: Mark Chappell
Fix unsafe conditional SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit dc7a3fb)
Fix unsafe conditional SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit dc7a3fb)
[PR #1984/dc7a3fb2 backport][stable-7] Fix unsafe conditional This is a backport of PR #1984 as merged into main (dc7a3fb). SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION
[PR #1984/dc7a3fb2 backport][stable-6] Fix unsafe conditional This is a backport of PR #1984 as merged into main (dc7a3fb). SUMMARY This fixes an unsafe conditional in integration tests that was missed by our previous mass updates for unsafe conditionals (#1891 and #1911). ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE
COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally