[PR #1891/dc080593 backport][stable-7] Avoid unsafe conditionals in integration tests #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Avoid unsafe conditionals in integration tests SUMMARY Update a batch of assertions in integration tests to avoid templating See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow. Affected tasks identified with: https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests ADDITIONAL INFORMATION There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit dc08059)
tremble
approved these changes
Dec 5, 2023
softwarefactory-project-zuul
bot
merged commit f42f76a
into
stable-7
40 of 41 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-7/dc0805937cc748bb26b4618ea7189dca7984a546/pr-1891
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1891 as merged into main (dc08059).
SUMMARY
Update a batch of assertions in integration tests to avoid templating
See: ansible/ansible-documentation#866 and ansible/ansible-documentation#866 for more information
This PR covers about half of the impacted test tasks for this repo but is already going to be a lot to get through CI so additional PRs will follow.
Affected tasks identified with:
https://gist.github.com/sivel/7b012ae2ebf4ab4cb6225379a72cc502
ISSUE TYPE
COMPONENT NAME
tests
ADDITIONAL INFORMATION
There are unsupported tests in this change. The cloudtrail tests seem to be broken independent of this change, iam_group tests pass for me locally