Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda layers support #1116

Closed
1 task done
thomaszooman opened this issue Jun 26, 2022 · 5 comments · Fixed by #1095
Closed
1 task done

AWS Lambda layers support #1116

thomaszooman opened this issue Jun 26, 2022 · 5 comments · Fixed by #1095
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@thomaszooman
Copy link

Summary

AWS Lambda now supports layers, it can reduce the code size and time spend dramatically. To support Lambda layers, it should be a new module to manage Lambda layers and update lambda module to support Lambda layers.

Issue Type

Feature Idea

Component Name

lambda

Additional Information

example of the lambda_layers module. lambda get-layer-version can retrieve the sha256 to determine upload new version or not.

lambda_layers: 
    name: node_modules
    zip_file: file_path
    # or
    s3_bucket: buclet_name
    s3_key: key_name
    runtimes:
    - 	nodejs12.x
    - 	nodejs14.x
    -   nodejs16.x
    architectures:
    -  x86_64
    -  arm64

lambda module

lambda:
    layers:
    -    layer1_arn
    -    layer2_arn
    ## other lambda parameters

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Jun 26, 2022
@alinabuzachis alinabuzachis transferred this issue from ansible-collections/community.aws Oct 5, 2022
@alinabuzachis
Copy link
Collaborator

alinabuzachis commented Oct 5, 2022

Hi @thomaszooman, @abikouo is working on this PR #1095 which is adding the requested module. Would you be willing to give it a try and let us know? Thank you.

@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@goneri
Copy link
Member

goneri commented Oct 11, 2022

Hi @thomaszooman, @abikouo is working on a set of new modules that should address your request. Can you give them a try?

#1095

softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 12, 2022
new modules: lambda_layer and lambda_layer_info

SUMMARY

The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

lambda_layer
lambda_layer_info
ADDITIONAL INFORMATION





Closes: #1116

Reviewed-by: Mark Chappell <None>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY

When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".

Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.

Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.

Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@0bde6bb
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
…ctions#1115)

execute_lambda - fix check mode and update RETURN docs

Depends-On: ansible-collections#1116
SUMMARY

check_mode fix
update RETURN docs to match what is actually being returned
require one of name, function_arn

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
execute_lambda
ADDITIONAL INFORMATION
I noticed some modules in community.aws will return data directly, and others will return data nested in a dict.
Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward?

Reviewed-by: Sloane Hertel <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f2ad637
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
rds_instance - add deletion_protection param

Depends-On: ansible-collections#1116
SUMMARY
Fixes ansible-collections#922
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@77cb097
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
…ections#1078)

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections#776
Depends-On: ansible-collections#1116
SUMMARY

Add support for copying a snapshot
Fixes ansible-collections#210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d04ab42
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c1d47dd
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this issue Apr 28, 2023
…1095)

new modules: lambda_layer and lambda_layer_info

SUMMARY

The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

lambda_layer
lambda_layer_info
ADDITIONAL INFORMATION





Closes: ansible-collections#1116

Reviewed-by: Mark Chappell <None>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this issue May 3, 2023
…_info (#1095) (#1495)

[manual backport stable-5] new modules: lambda_layer and lambda_layer_info (#1095)

new modules: lambda_layer and lambda_layer_info
SUMMARY
The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
lambda_layer
lambda_layer_info
ADDITIONAL INFORMATION
Closes: #1116
Reviewed-by: Mark Chappell 
Reviewed-by: Bikouo Aubin 
Reviewed-by: Jill R 
Reviewed-by: Alina Buzachis 
Reviewed-by: Gonéri Le Bouder [email protected]
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ctions#1115)

execute_lambda - fix check mode and update RETURN docs

Depends-On: ansible-collections#1116
SUMMARY

check_mode fix
update RETURN docs to match what is actually being returned
require one of name, function_arn

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
execute_lambda
ADDITIONAL INFORMATION
I noticed some modules in community.aws will return data directly, and others will return data nested in a dict.
Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward?

Reviewed-by: Sloane Hertel <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
rds_instance - add deletion_protection param

Depends-On: ansible-collections#1116
SUMMARY
Fixes ansible-collections#922
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ections#1078)

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections#776
Depends-On: ansible-collections#1116
SUMMARY

Add support for copying a snapshot
Fixes ansible-collections#210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ctions#1115)

execute_lambda - fix check mode and update RETURN docs

Depends-On: ansible-collections#1116
SUMMARY

check_mode fix
update RETURN docs to match what is actually being returned
require one of name, function_arn

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
execute_lambda
ADDITIONAL INFORMATION
I noticed some modules in community.aws will return data directly, and others will return data nested in a dict.
Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward?

Reviewed-by: Sloane Hertel <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
rds_instance - add deletion_protection param

Depends-On: ansible-collections#1116
SUMMARY
Fixes ansible-collections#922
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
…ections#1078)

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections#776
Depends-On: ansible-collections#1116
SUMMARY

Add support for copying a snapshot
Fixes ansible-collections#210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
…ctions#1115)

execute_lambda - fix check mode and update RETURN docs

Depends-On: ansible-collections#1116
SUMMARY

check_mode fix
update RETURN docs to match what is actually being returned
require one of name, function_arn

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
execute_lambda
ADDITIONAL INFORMATION
I noticed some modules in community.aws will return data directly, and others will return data nested in a dict.
Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward?

Reviewed-by: Sloane Hertel <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
rds_instance - add deletion_protection param

Depends-On: ansible-collections#1116
SUMMARY
Fixes ansible-collections#922
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
…ections#1078)

rds_instance_snapshot - add copy snapshot functionality

Depends-On: ansible-collections#776
Depends-On: ansible-collections#1116
SUMMARY

Add support for copying a snapshot
Fixes ansible-collections#210
Don't require db_instance_identifier on state = present (only required for creation)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants