fix ignore_nonexistent_bucket bug for listing (#966) #967
Conversation
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for taking the time to submit this PR.
The change looks sensible, and I'm not sure we can cleanly test the behaviour in CI. However, it would be good if you could include a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
|
@akiuni please create a changelog fragment file. the main changelog.yml file is updated as part of our release process https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to |
|
This test is failing , I don't know why because I didn't change anything in AWS certificate Service. |
|
recheck |
|
@akiuni I suspect this is a quirk of the way we identify cross-repo impacts (a change to the ACM utility code landed yesterday) I've asked it to re-run the tests, if they still fail I'll try rebasing your change |
|
Thx for your answer, it worked fine :) now waiting for ansible gate I suppose |
|
@akiuni the "gate" tests are used for the final merge, I was waiting for the tests to pass before triggering them. |
…s#1162) Fix issue when creating GSI with global_keys_only SUMMARY fixes: ansible-collections#967 Undocumented requirement on NonKeyAttributes that it should be omitted rather than an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1 fatal: [localhost]: FAILED! => {"boto3_version": "1.18.47", "botocore_version": "1.21.47", "changed": false, "msg": "Failed to update table: Parameter validation failed:\nInvalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1"} Reviewed-by: Markus Bergholz <[email protected]>
…s#1162) Fix issue when creating GSI with global_keys_only SUMMARY fixes: ansible-collections#967 Undocumented requirement on NonKeyAttributes that it should be omitted rather than an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1 fatal: [localhost]: FAILED! => {"boto3_version": "1.18.47", "botocore_version": "1.21.47", "changed": false, "msg": "Failed to update table: Parameter validation failed:\nInvalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1"} Reviewed-by: Markus Bergholz <[email protected]>
…s#1162) Fix issue when creating GSI with global_keys_only SUMMARY fixes: ansible-collections#967 Undocumented requirement on NonKeyAttributes that it should be omitted rather than an empty list. ISSUE TYPE Bugfix Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Invalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1 fatal: [localhost]: FAILED! => {"boto3_version": "1.18.47", "botocore_version": "1.21.47", "changed": false, "msg": "Failed to update table: Parameter validation failed:\nInvalid length for parameter GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes, value: 0, valid min length: 1"} Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
remove duplicated use of bucket_check() and reuse bucketrtn instead
Fixes #966
ISSUE TYPE
COMPONENT NAME
s3_object
ADDITIONAL INFORMATION