-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route53: add wait_id return value in case of changes #1683
route53: add wait_id return value in case of changes #1683
Conversation
(Documentation of API result: https://docs.aws.amazon.com/Route53/latest/APIReference/API_ChangeInfo.html → shows that |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 32s |
5.6.0 isn't currently planned (not written off, but not planned) |
A corresponding route53_wait module that uses this return value can be found in ansible-collections/community.aws#1904. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 50s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
1277d48
to
afca5a8
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 32s |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/6741f14094114677ba2454f02847f6c1 ✔️ ansible-galaxy-importer SUCCESS in 4m 46s |
regate |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 03s |
Pull request merge failed: Required status check "ansible/check" is expected. |
afca5a8
to
474f6a2
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 58s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 07s |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1686 🤖 @patchback |
route53: add wait_id return value in case of changes SUMMARY This allows to wait for changes later on when wait=false is provided to the module. Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :) (I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.) ISSUE TYPE Feature Pull Request COMPONENT NAME route53 Reviewed-by: Mark Chappell (cherry picked from commit 983cbe9)
[PR #1683/983cbe90 backport][stable-6] route53: add wait_id return value in case of changes This is a backport of PR #1683 as merged into main (983cbe9). SUMMARY This allows to wait for changes later on when wait=false is provided to the module. Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :) (I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.) ISSUE TYPE Feature Pull Request COMPONENT NAME route53 Reviewed-by: Alina Buzachis
@tremble @hakbailey @alinabuzachis thanks a lot! |
…ions#1683) route53: add wait_id return value in case of changes SUMMARY This allows to wait for changes later on when wait=false is provided to the module. Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :) (I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.) ISSUE TYPE Feature Pull Request COMPONENT NAME route53 Reviewed-by: Mark Chappell
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit a7cddf0)
[PR #1904/a7cddf0e backport][stable-6] Add route53_wait module This is a backport of PR #1904 as merged into main (a7cddf0). SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]>
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
Add route53_wait module SUMMARY Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false. Depends on ansible-collections#1683, thus the tests shouldn't really do anything right now. ISSUE TYPE New Module Pull Request COMPONENT NAME route53 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
SUMMARY
This allows to wait for changes later on when
wait=false
is provided to the module.Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update
version_added
and thebackport-5
label needs to be removed.)ISSUE TYPE
COMPONENT NAME
route53