ec2_ami: refactoring and unit-test coverage #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
WIP
goneri
force-pushed
the
ec2_ami-unit-test-coverage_22700
branch
from
335f7b0 to
553d8cb
Compare
goneri
force-pushed
the
ec2_ami-unit-test-coverage_22700
branch
from
553d8cb to
6d3a9d0
Compare
goneri
changed the title
goneri
force-pushed
the
ec2_ami-unit-test-coverage_22700
branch
from
6d3a9d0 to
50053dc
Compare
alinabuzachis
approved these changes
Oct 18, 2022
gravesm
approved these changes
Oct 19, 2022
Refactoring and unit-test coverage of the `ec2_ami`. - Break up the long `create_image()`, `deregister_image()`, `update_image()` - Use classes and static methods to group the functions - Use more Pythonic expression when possible - Handle internal failures with exception to simplify the error managment
tremble
force-pushed
the
ec2_ami-unit-test-coverage_22700
branch
from
50053dc to
bc6bab6
Compare
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ections#1165) s3_lifecycle - drop deprecated requester_pays parameter SUMMARY The requester_pays did nothing, drop it. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See also: ansible/ansible#63989 Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ections#1165) s3_lifecycle - drop deprecated requester_pays parameter SUMMARY The requester_pays did nothing, drop it. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See also: ansible/ansible#63989 Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ections#1165) s3_lifecycle - drop deprecated requester_pays parameter SUMMARY The requester_pays did nothing, drop it. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION See also: ansible/ansible#63989 Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and unit-test coverage of the
ec2_ami.create_image(),deregister_image(),update_image()