Skip to content

Commit

Permalink
ec2_ami: refactoring and unit-test coverage (#1165)
Browse files Browse the repository at this point in the history
ec2_ami: refactoring and unit-test coverage

Refactoring and unit-test coverage of the ec2_ami.

Break up the long create_image(), deregister_image(), update_image()
Use classes and static methods to group the functions
Use more Pythonic expression when possible
Handle internal failures with exception to simplify the error managment

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mike Graves <[email protected]>
  • Loading branch information
goneri authored Oct 20, 2022
1 parent 6d1b2ea commit 1de120d
Show file tree
Hide file tree
Showing 3 changed files with 794 additions and 287 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/ec2_ami_test-coverage.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
minor_changes:
- "ec2_ami - Extend the unit-test coverage of the module (https://github.com/ansible-collections/amazon.aws/pull/1159)."
Loading

0 comments on commit 1de120d

Please sign in to comment.