Deprecate module_utils.urls #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
Oct 11, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1154 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
Deprecate module_utils.urls SUMMARY Originally introduced in ansible/ansible#42758, as far as I can tell the module_utils/urls.py has never actually been used by a module. It's primary purpose was to add support for Sigv4, but boto3/botocore support this out of the box now and we shouldn't be reimplementing it. We have no tests for this code, nothing's using it, and it's in the "supported" repo. Let's prune out this code, if someone external's using it hopefully someone will raise an issue and we can reconsider the deprecation. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/urls.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 90eda33)
tremble
pushed a commit
that referenced
this pull request
Oct 11, 2022
Deprecate module_utils.urls SUMMARY Originally introduced in ansible/ansible#42758, as far as I can tell the module_utils/urls.py has never actually been used by a module. It's primary purpose was to add support for Sigv4, but boto3/botocore support this out of the box now and we shouldn't be reimplementing it. We have no tests for this code, nothing's using it, and it's in the "supported" repo. Let's prune out this code, if someone external's using it hopefully someone will raise an issue and we can reconsider the deprecation. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/urls.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 90eda33)
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
aws_secret - Support purge_tags
SUMMARY
aws_secret currently defaults to purging all tags (even if tags isn't specified), this is a little aggressive.
Add purge_tags parameter
Only purge tags if tags: {} is set (rather than when tags is None
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
Related to ansible-collections#1146
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
aws_secret - Support purge_tags
SUMMARY
aws_secret currently defaults to purging all tags (even if tags isn't specified), this is a little aggressive.
Add purge_tags parameter
Only purge tags if tags: {} is set (rather than when tags is None
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
Related to ansible-collections#1146
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
aws_secret - Support purge_tags
SUMMARY
aws_secret currently defaults to purging all tags (even if tags isn't specified), this is a little aggressive.
Add purge_tags parameter
Only purge tags if tags: {} is set (rather than when tags is None
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
Related to ansible-collections#1146
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add changelog fragment for amazon.aws/825 SUMMARY With ansible-collections#825 we now ignore aws: tags when purging. Since affects both amazon.aws and community.aws add a changelog note to community.aws ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/817-skip_purge_aws.yaml ADDITIONAL INFORMATION See also: ansible-collections#825 ansible-collections#817 ansible-collections#1146 Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Originally introduced in ansible/ansible#42758, as far as I can tell the module_utils/urls.py has never actually been used by a module. It's primary purpose was to add support for Sigv4, but boto3/botocore support this out of the box now and we shouldn't be reimplementing it.
We have no tests for this code, nothing's using it, and it's in the "supported" repo. Let's prune out this code, if someone external's using it hopefully someone will raise an issue and we can reconsider the deprecation.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/urls.py
ADDITIONAL INFORMATION