Do not purge 'aws:*' tags #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
ansibullbot
added
community_review
feature
This comment was marked as outdated.
This comment was marked as outdated.
alinabuzachis
approved these changes
May 20, 2022
|
recheck |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
…being deleted under us
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
jatorcasso
approved these changes
May 26, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
May 30, 2022
Add changelog fragment for amazon.aws/825 SUMMARY With ansible-collections/amazon.aws#825 we now ignore aws: tags when purging. Since affects both amazon.aws and community.aws add a changelog note to community.aws ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/817-skip_purge_aws.yaml ADDITIONAL INFORMATION See also: ansible-collections/amazon.aws#825 ansible-collections/amazon.aws#817 #1146 Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ansible-collections#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See ansible-collections#825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes: #817
According to the AWS documentation
The most common use case here is AWS CloudFormation, which adds a "aws:cloudformation:stack-name" tag. Since we can't manage these tags at all we should ignore them for the purposes of 'purging'. If someone explicitly adds the tag, then it's reasonable to let the APIs throw an error at them, but otherwise do the best we can.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/tagging.py
ADDITIONAL INFORMATION