[PR #1146/90eda33f backport][stable-5] Deprecate module_utils.urls #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Deprecate module_utils.urls SUMMARY Originally introduced in ansible/ansible#42758, as far as I can tell the module_utils/urls.py has never actually been used by a module. It's primary purpose was to add support for Sigv4, but boto3/botocore support this out of the box now and we shouldn't be reimplementing it. We have no tests for this code, nothing's using it, and it's in the "supported" repo. Let's prune out this code, if someone external's using it hopefully someone will raise an issue and we can reconsider the deprecation. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/urls.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 90eda33)
ansibullbot
added
community_review
feature
tremble
approved these changes
Oct 11, 2022
|
Failed test is just changelog which appears to be flaky |
tremble
deleted the
patchback/backports/stable-5/90eda33f6af558e875db471f5704bb8ddfcfb2ac/pr-1146
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1146 as merged into main (90eda33).
SUMMARY
Originally introduced in ansible/ansible#42758, as far as I can tell the module_utils/urls.py has never actually been used by a module. It's primary purpose was to add support for Sigv4, but boto3/botocore support this out of the box now and we shouldn't be reimplementing it.
We have no tests for this code, nothing's using it, and it's in the "supported" repo. Let's prune out this code, if someone external's using it hopefully someone will raise an issue and we can reconsider the deprecation.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/urls.py
ADDITIONAL INFORMATION