[PR #1151/a9ad1808 backport][stable-5] ec2_instance - update build_run_instance_spec to skip TagSpecification if None #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…n if None (#1151) ec2_instance - update build_run_instance_spec to skip TagSpecification if None SUMMARY fixes: #1148 When no tags are supplied, build_run_instance_spec currently includes 'TagSpecification': None. This results in botocore throwing an exception. Also renames instance_role to iam_instance_profile (keeping the original as an alias). While this could be split off, I'll just perform a partial backport for the bugfix when backporting to 4.x, while working through some unit tests the inaccuracy of the parameter name was apparent. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_instance.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]> (cherry picked from commit a9ad180)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
bug
tremble
approved these changes
Oct 12, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
regate |
|
regate |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/a9ad1808f2e87837eed23d71cac3e35b1d433d23/pr-1151
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
data_pipeline - remove unused version option SUMMARY The version option has always been ignored and has now been removed. ISSUE TYPE Feature Pull Request COMPONENT NAME data_pipeline ADDITIONAL INFORMATION See also: ansible/ansible#64368 Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
data_pipeline - remove unused version option SUMMARY The version option has always been ignored and has now been removed. ISSUE TYPE Feature Pull Request COMPONENT NAME data_pipeline ADDITIONAL INFORMATION See also: ansible/ansible#64368 Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
data_pipeline - remove unused version option SUMMARY The version option has always been ignored and has now been removed. ISSUE TYPE Feature Pull Request COMPONENT NAME data_pipeline ADDITIONAL INFORMATION See also: ansible/ansible#64368 Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1151 as merged into main (a9ad180).
SUMMARY
fixes: #1148
When no tags are supplied, build_run_instance_spec currently includes
'TagSpecification': None. This results in botocore throwing an exception.Also renames
instance_roletoiam_instance_profile(keeping the original as an alias). While this could be split off, I'll just perform a partial backport for the bugfix when backporting to 4.x, while working through some unit tests the inaccuracy of the parameter name was apparent.ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_instance.py
ADDITIONAL INFORMATION