DNM: module_utils.modules: expose module.params as a readonly dict #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
changed the title
|
I don't necessary want to get this merge. it's a test to see how many tests fail with something like this. |
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
module_utils
|
check ondemand |
|
@goneri Wow, that looks kinda spectacular (although I suspect ec2_instance may be responsible for much of that) |
|
check ondemand |
|
check ondemand |
Use a MappingProxyType without backend to ensure the `module.params` dict is readonly.
tremble
force-pushed
the
module_utils.modules-expose-module.params-as-a-readonly-dict_30660
branch
from
7c7adf6 to
06142c4
Compare
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Jan 11, 2023
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Jan 11, 2023
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Jan 11, 2023
|
closing for now, probably get sporadically re-opened. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 23, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 24, 2024
…urge_tags default is True (ansible-collections#1183) Tagging - remove default empty dict where purge_tags default is True Depends-On: ansible-collections#844 SUMMARY Move modules over to the new tagging fragment Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_transit_gateway.py plugins/modules/efs.py plugins/modules/eks_fargate_profile.py plugins/modules/elb_target_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7d98adc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depended-On: #1187
Depended-On: ansible-collections/community.aws#1567
Use a MappingProxyType with no backend to ensure the
module.paramsdict is readonly.