elb_target_group: do not modify module.params structure #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the logic to avoid the modification of `module.params` structure.
goneri
force-pushed
the
elb_target_group-do-not-modify-module.params-structure_17291
branch
from
f9b8beb to
d108aaa
Compare
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
module
|
recheck |
|
recheck |
tremble
approved these changes
Feb 8, 2023
|
setting target_type causes the "required_if" clauses to be evaluated, even if state=absent. Closing this as abandoned for now |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ilter added (ansible-collections#1570) ACMServiceManager.list_certificates_with_backoff: explicit key type filter added SUMMARY Fixes ansible-collections#1567 ACM.Client.list_certificates requires explicit certificate type filter in order to return the non-RSA_2048 certificates too, and this is needed to ensure the idempotency of importing such certificates. ISSUE TYPE Bugfix Pull Request COMPONENT NAME acm Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the logic to avoid the modification of
module.paramsstructure.