Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda_info and lambda_alias - avoid manipulating module.params #1336

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 11, 2023

SUMMARY

Directly manipulating module.params results in the Ansible output incorrectly representing what was passed to the module, as such we shouldn't be doing this.

  • Refactors lambda_alias to avoid passing around "module" entirely
  • Updates lamba_info to avoid updating module.params
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lambda_info
lambda_alias

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @pjodouin @ryansb @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 11, 2023
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble tremble force-pushed the module_params/lambda branch from 1de2d5f to 22efc39 Compare January 11, 2023 09:02
@tremble tremble force-pushed the module_params/lambda branch from 22efc39 to c83cccf Compare January 11, 2023 09:29
@tremble tremble marked this pull request as ready for review January 11, 2023 09:29
@tremble tremble requested a review from alinabuzachis January 11, 2023 09:29
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 6m 29s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 12m 00s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 52s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 09s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 43s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 39s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 22s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 34s
✔️ cloud-tox-py3 SUCCESS in 6m 16s
✔️ ansible-test-changelog SUCCESS in 2m 26s
✔️ ansible-test-splitter SUCCESS in 3m 20s
✔️ integration-amazon.aws-1 SUCCESS in 11m 27s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 11, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 6m 23s
✔️ ansible-test-splitter SUCCESS in 3m 40s
✔️ integration-amazon.aws-1 SUCCESS in 15m 13s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 28m 21s
✔️ integration-community.aws-2 SUCCESS in 20m 48s
✔️ integration-community.aws-3 SUCCESS in 54m 28s
✔️ integration-community.aws-4 SUCCESS in 12m 04s
✔️ integration-community.aws-5 SUCCESS in 31m 17s
✔️ integration-community.aws-6 SUCCESS in 29m 06s
✔️ integration-community.aws-7 SUCCESS in 1h 00m 12s
✔️ integration-community.aws-8 SUCCESS in 33m 23s
✔️ integration-community.aws-9 SUCCESS in 30m 17s
✔️ integration-community.aws-10 SUCCESS in 16m 02s
✔️ integration-community.aws-11 SUCCESS in 21m 04s
✔️ integration-community.aws-12 SUCCESS in 15m 05s
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6359b98 into ansible-collections:main Jan 11, 2023
@tremble tremble deleted the module_params/lambda branch February 15, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants