Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Backports for 1.0.2 #29444

Merged
merged 109 commits into from
Nov 3, 2018
Merged

WIP: Backports for 1.0.2 #29444

merged 109 commits into from
Nov 3, 2018

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 30, 2018

Backported PRs:

Non-merged PRs with backport label:

githubtomtom and others added 30 commits September 30, 2018 12:58
(cherry picked from commit 5dda994)
Alternative based on #29187

Tests from rforquet's PR linked above.

(cherry picked from commit 16516b5)
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes.

(cherry picked from commit 6354405)
Minor language fixes. Two more significant changes are:
* it is recommended to use `===` to compare to `nothing`
* `=` is not a binary operator

(cherry picked from commit 27de698)
I spotted a typo when reviewing the merge.

(cherry picked from commit 338cf0d)
The R function is called is.na, and automatically works element-wise.

(cherry picked from commit 8484f97)
Fixes #29297, see discussion there.

(cherry picked from commit 64a4f18)
(cherry picked from commit c37f4aa)
* gemm_wrapper! -> mul! (#29224)

* testing for #29224

* code review update: More tests

* Complex times real reinterpret trick fix for vectors and transposed matrices

(cherry picked from commit 82503cd)
__ldexp_exp(f) requires the second argument to be an Int32, so we might as well hard-code that here. It also seems that the old specification is actually not valid, or might have unexpected results, so we should just go with Int32, see #29400 .

(cherry picked from commit 75f798f)
Move whereas clause into subordinate position to avoid sentence fragment.

(cherry picked from commit 8907aff)
fredrikekre and others added 19 commits November 2, 2018 16:43
(cherry picked from commit 82c4fce)
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
* speed up logical indexing by bitarray

* changed inbounds / OOB behavior to match array iterators

switched spelling of _blsr

* Update base/multidimensional.jl

Co-Authored-By: chethega <[email protected]>
(cherry picked from commit 44f2563)
* Remove Pkg from the JuliaLang/julia repo.

* Use git-external to install Pkg during build.

(cherry picked from commit 1717adb)
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
Oops.

fixes #29836, and adds explicit test coverage

(cherry picked from commit e270fbb)
This was broken when `findfirst` was deprecated in 9bdf07f.

(cherry picked from commit 3aeccec)
Fixes #29723

(cherry picked from commit a472bc7)
Co-authored-by: Jameson Nash <[email protected]>
(cherry picked from commit 6ae6551)
* fix bug and add tests

* Reinstate statically computed log record ids

Log ids are meant to identify the location of the message in the source
code and must be computed at compile time.

fix #28786, fix #28400; closes #29355.

* Clarify documentation regarding log record `id`

(cherry picked from commit 51683c4)
@KristofferC
Copy link
Member Author

Removed #29726 and added #29908 (since it was requested). @ararslan think we are ready for another round.

@ararslan ararslan removed the needs pkgeval Tests for all registered packages should be run with this change label Nov 3, 2018
@ararslan
Copy link
Member

ararslan commented Nov 3, 2018

PkgEval says we're all good now. 😎

@fredrikekre
Copy link
Member

Merge and announce a short testing period like last time?

@KristofferC
Copy link
Member Author

Sounds good to me.

@ararslan ararslan merged commit b196720 into release-1.0 Nov 3, 2018
@ararslan ararslan deleted the backport_102 branch November 3, 2018 19:46
@ararslan
Copy link
Member

ararslan commented Nov 3, 2018

Thanks for all of your awesome work here, Kristoffer!

@ararslan
Copy link
Member

ararslan commented Nov 3, 2018

Testing period announcement: https://discourse.julialang.org/t/julia-1-0-2-testing-period/17121?u=ararslan

@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.