REPL: show "failed" when i-search fails, like in readline #29413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The i-search prompt becomes for example: `(failed forward-i-search)`.
|
backport? |
KristofferC
pushed a commit
that referenced
this pull request
Oct 6, 2018
The i-search prompt becomes for example: `(failed forward-i-search)`. (cherry picked from commit 37ab710)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
The i-search prompt becomes for example: `(failed forward-i-search)`. (cherry picked from commit 37ab710)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
The i-search prompt becomes for example: `(failed forward-i-search)`. (cherry picked from commit 37ab710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i-search prompt becomes for example:
(failed forward-i-search).We are still far from ipython's incremental search, but this is a little usability improvement.