Uniform scaling cat with zero dimensions #29457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfalt
commented
Oct 1, 2018
| for i = 1:nr | ||
| nci = 0 | ||
| rows[i] > 0 && n[j+1] == 0 && continue # column count unknown in this row | ||
| rows[i] > 0 && n[j+1] == -1 && (j += rows[i]; continue) |
There was a problem hiding this comment.
There should have been some kind of bug here previously, but I can't figure out how.
|
The tests passed on travis, not sure why it shows up as pending. |
|
Sometimes the Travis test success notification doesn't propagate to the GitHub window. Seems to happen more often recently. Looks good to me, great that you added so many extra tests. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 29, 2018
* Uniform scaling cat with zero dimensions * Missing type assertion in test (cherry picked from commit 4093dbf)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Uniform scaling cat with zero dimensions * Missing type assertion in test (cherry picked from commit 4093dbf)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* Uniform scaling cat with zero dimensions * Missing type assertion in test (cherry picked from commit 4093dbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve issue of cat with matrices with zero sizes, see: #29456
I tried to catch as many corner cases as possible, should the tests be in a separate testset for the issue?