Skip to content

Commit

Permalink
Remove docstring relicts of findlast/findprev for regex (#29398)
Browse files Browse the repository at this point in the history
  • Loading branch information
@laborg @nalimilan
laborg authored and nalimilan committed Sep 27, 2018
1 parent 8d5c109 commit 47668c8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions base/strings/search.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ findnext(t::AbstractString, s::AbstractString, i::Integer) = _search(s, t, i)

"""
findlast(pattern::AbstractString, string::AbstractString)
findlast(pattern::Regex, string::String)
Find the last occurrence of `pattern` in `string`. Equivalent to
[`findlast(pattern, string, lastindex(s))`](@ref).
Expand Down Expand Up @@ -406,11 +405,8 @@ end

"""
findprev(pattern::AbstractString, string::AbstractString, start::Integer)
findprev(pattern::Regex, string::String, start::Integer)
Find the previous occurrence of `pattern` in `string` starting at position `start`.
`pattern` can be either a string, or a regular expression, in which case `string`
must be of type `String`.
The return value is a range of indices where the matching sequence is found, such that
`s[findprev(x, s, i)] == x`:
Expand Down

2 comments on commit 47668c8

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.