Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: make paste work in search mode #29373

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Conversation

rfourquet
Copy link
Member

No description provided.

@rfourquet rfourquet added REPL Julia's REPL (Read Eval Print Loop) bugfix This change fixes an existing bug labels Sep 26, 2018
@KristofferC
Copy link
Member

Note that the example in #29347 can be reproduced without using paste at all so it is not an only paste issue, or?

@rfourquet
Copy link
Member Author

Actually, I couldn't reproduce the issue without using paste at all, so was not sure... (maybe it can depend on the content of the history file?)
On the other hand, pasting triggers reliably the bug, even if I paste non-gibberish (which matches something in history). If you confirm, I will remove the "fix ..." from the title.

@KristofferC
Copy link
Member

You need to write something that gives zero results in the reverse search. Å did it for me

(reverse-i-search)`Å': ┌ Error: Error in the keymap
│   exception =
│    BoundsError: attempt to access ""
│      at index [0]
│    Stacktrace:

So, Ctrl-R, Å, Ctrl-R was my input there

@rfourquet
Copy link
Member Author

Ok I can reproduce, so there seems to be two bugs here!

@rfourquet
Copy link
Member Author

I indentified the problem, I will make a fix for the second bug.

@rfourquet
Copy link
Member Author

For reference, the bug was introduced in #25646 which introduced the keep keyword to readuntil.

@rfourquet rfourquet changed the title REPL: make paste work in search mode (fix #29347) REPL: make paste work in search mode Oct 4, 2018
@rfourquet rfourquet merged commit 9280bfc into master Oct 4, 2018
@rfourquet rfourquet deleted the rf/repl/fix-paste-rsearch branch October 4, 2018 14:00
KristofferC pushed a commit that referenced this pull request Oct 6, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants