Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propgate inbounds to substring and use it in split #29557

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Conversation

KristofferC
Copy link
Member

Using it in split is mostly a proof of concept that the propagation works,

Before

julia> @btime split("str,str,str,str,str,str,str", ",")
  745.398 ns (10 allocations: 432 bytes)

After

julia> @btime split("str,str,str,str,str,str,str", ",")
  662.151 ns (10 allocations: 432 bytes)

Ref #26818

@KristofferC KristofferC added performance Must go faster strings "Strings!" labels Oct 7, 2018
@KristofferC KristofferC merged commit 18b9fc2 into master Oct 16, 2018
@StefanKarpinski StefanKarpinski deleted the kc/inb_subs branch October 16, 2018 14:56
KristofferC added a commit that referenced this pull request Oct 29, 2018
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Oct 31, 2018
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Nov 2, 2018
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Feb 11, 2019
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Feb 20, 2020
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants