Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundscheck blocks for SubString should perhaps be propagated #29554

Closed
KristofferC opened this issue Oct 7, 2018 · 1 comment
Closed

Boundscheck blocks for SubString should perhaps be propagated #29554

KristofferC opened this issue Oct 7, 2018 · 1 comment
Labels
performance Must go faster strings "Strings!"

Comments

@KristofferC
Copy link
Member

KristofferC commented Oct 7, 2018 •
edited
Loading 

julia> f(s) = @inbounds SubString(s, 1, 5)
fff (generic function with 1 method)

julia> f("dsf")
ERROR: BoundsError: attempt to access "dsf"
  at index [1:5]

Perhaps the boundscheck from the outer constructor should be propagated to the inner constructor.
@KristofferC KristofferC added performance Must go faster regression Regression in behavior compared to a previous version strings "Strings!" and removed regression Regression in behavior compared to a previous version labels Oct 7, 2018
@KristofferC KristofferC changed the title Boundscheck blocks for SubString seems useless Boundscheck blocks for SubString should perhaps be propagated Oct 7, 2018
@KristofferC
Copy link
Member Author

Fixed by #29557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Must go faster strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KristofferC