convert Integer in Cholesky constructors to BlasInt #29732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? That would have caught this when building distro packages. |
nalimilan
approved these changes
Oct 19, 2018
andreasnoack
approved these changes
Oct 19, 2018
nalimilan
reviewed
Oct 19, 2018
stdlib/LinearAlgebra/src/cholesky.jl
Outdated
| CholeskyPivoted{T,typeof(A)}(A, uplo, piv, rank, tol, info) | ||
| function CholeskyPivoted(A::AbstractMatrix{T}, uplo::AbstractChar, piv::Vector{<:Integer}, | ||
| rank::Integer, tol::Real, info::Integer) where T | ||
| CholeskyPivoted{T,typeof(A)}(A, uplo, Vector{BlasInt}(piv), BlasInt(rank), tol, |
There was a problem hiding this comment.
Mmm, I missed this, but it's going to make a copy even when not needed. Better use convert.
stdlib/LinearAlgebra/src/cholesky.jl
Outdated
| Cholesky(A::AbstractMatrix{T}, uplo::AbstractChar, info::BlasInt) where {T} = | ||
| Cholesky{T,typeof(A)}(A, uplo, info) | ||
| Cholesky(A::AbstractMatrix{T}, uplo::Symbol, info::Integer) where {T} = | ||
| Cholesky{T,typeof(A)}(A, char_uplo(uplo), BlasInt(info)) |
There was a problem hiding this comment.
Actually, I shouldn't even be necessary to convert explicitly to BlasInt. The conversion will happen implicitly if you just pass info and it is slightly cleaner.
There was a problem hiding this comment.
is that true of the Vector too?
There was a problem hiding this comment.
Yes. It should also be the case for `Vector.
|
Okay I've removed all the conversions so the only change is broadening the methods to accept |
KristofferC
pushed a commit
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 53563cd)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit 53563cd)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 53563cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack with @nalimilan and @mbauman, this loosens the constructors for
Choleskyto allowIntegerinfoarguments, which are converted toBlasInt.Fixes JuliaStats/MixedModels.jl#143 (which is caused by
BlasInt=Int32on builds with non-ILP64 BLAS, like arch linux).