Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Dates.Time as dictionary keys #29480

Closed
marekkukan-tw opened this issue Oct 2, 2018 · 1 comment
Closed

Using Dates.Time as dictionary keys #29480

marekkukan-tw opened this issue Oct 2, 2018 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior dates Dates, times, and the Dates stdlib module

Comments

@marekkukan-tw
Copy link
Contributor

I found this problem when I tried using Dates.Time as dictionary keys:

julia> a = Dates.Time(0)
00:00:00

julia> b = Dates.Time(0) + Dates.Hour(24)
00:00:00

julia> a == b
true

julia> isequal(a, b)
true

julia> hash(a) == hash(b)
false
@KristofferC KristofferC added bug Indicates an unexpected problem or unintended behavior dates Dates, times, and the Dates stdlib module labels Oct 2, 2018
@StefanKarpinski
Copy link
Member

cc @quinnj

quinnj added a commit that referenced this issue Oct 4, 2018
@quinnj
Fix hashing of Dates.Time. Fixes #29480
67aa478
quinnj added a commit that referenced this issue Oct 4, 2018
@quinnj
Fix hashing of Dates.Time. Fixes #29480
1229ee4
quinnj added a commit that referenced this issue Oct 4, 2018
@quinnj
Fix hashing of Dates.Time. Fixes #29480
555571e
JeffBezanson pushed a commit that referenced this issue Oct 20, 2018
@quinnj @JeffBezanson
Fix hashing of Dates.Time. Fixes #29480
32f26ef
KristofferC pushed a commit that referenced this issue Oct 29, 2018
@JeffBezanson @KristofferC
Fix hashing of Dates.Time. Fixes #29480 (#29742)
116b091 
(cherry picked from commit 1db6047)
@KristofferC KristofferC mentioned this issue Oct 29, 2018
Merged
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@JeffBezanson @KristofferC
Fix hashing of Dates.Time. Fixes #29480 (#29742)
b7977ca 
(cherry picked from commit 1db6047)
KristofferC pushed a commit that referenced this issue Feb 20, 2020
@JeffBezanson @KristofferC
Fix hashing of Dates.Time. Fixes #29480 (#29742)
197d443 
(cherry picked from commit 1db6047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @KristofferC @marekkukan-tw