Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using LinearAlgebra explicit #29188

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Conversation

stillyslalom
Copy link
Contributor

Ref. https://discourse.julialang.org/t/error-undefvarerror-eigvecs-not-defined/14923/2?u=stillyslalom

An aside: using LinearAlgebra is already embedded in DocTestSetup. Is there (or should there be) a way to seamlessly make this visible in the resulting doc page?

@stillyslalom
Copy link
Contributor Author

Bump. This added detail to one line in the manual, and can be safely merged.

@andreasnoack andreasnoack merged commit 2c15430 into JuliaLang:master Sep 17, 2018
@KristofferC KristofferC added the docs This change adds or pertains to documentation label Sep 17, 2018
@andreasnoack
Copy link
Member

We could consider adding using LinearAlgebra explicitly to the examples to make them self-contained.

@stillyslalom stillyslalom deleted the patch-6 branch September 17, 2018 16:27
@stillyslalom
Copy link
Contributor Author

There are six examples on the LinearAlgebra page, and the other stdlib doc pages are similar in that respect. It seems better to say

The following examples' dependencies should first be loaded by using xxxxx

at the top of the page rather than adding line noise to each example, especially since that header line can be generated using information already provided in DocTestSetup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants