Deploy Checklist: New Expensify 2023-12-11

[github-actions]

Release Version: 1.4.11-25
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor the money request creation flow #28618
• [TS Migration] Migrate 'FormHelpMessage.js' component to TypeScript #30487
• fix: unify word breaking in ContextMenuItem for Android mweb and Android native #31116
• Fix: App crashes on open notification #31481
• [TS migration] Migrate 'Tooltip' component to TypeScript #31544
• [TS migration] Migrate 'FlatList' component to TypeScript #31697
• [TS migration] Migrate remaining libs to TypeScript #32206
• fix: hide emoji picker for deleted parent action #32209
• Refactor the PersistedRequests v2 #32246
• fix: Update task title without opening the report #32249
• [TS migration] Migrate 'UnreadIndicatorUpdater' lib to TypeScript #32272
• Restore transaction when not saving distance in edit page #32334
• [No QA][Cleanup] Always use constants for screen names #32430
• Truncate long items in the SelectionList #32532
• Design adjustments for the Next Steps message #32561
• [No QA] Add new change log constant for bulk tag updates #32595
• [Bug resolution] for [#31822: Conversation disappears from LHN when creating an IOU with a new user in offline mode] #32633
• Add perf tests for ReportUtils #32637
• Fix: updated copy in promote referral #32673
• Fix copying submitted message copies nothing #32676
• Update BBA error message for unvalidated accounts #32706
• [NoQA] dev: fix e2e test running in dev mode #32713
• [No QA] fix style regressions #32746
• Fix error when pressing the split button on the split bill details page with a receipt #32821
• fix: getting unselected participants #32823
• [CP Stag] Remove unnecessary chatOptions computation #32847
• fix: Handle brief NotFound page on the Request Money flow #32849
• [CP Staging] fix: store selected currency in URL query temporarily #32851
• fix unable to scan receipt, the camera error display #32854
• Hide three dot menu on split requests #32866
• [CP Staging] Fix missing header #32877
• [CP Staging] Track when a split is created from global create to call proper API #32878
• Fix amount reset #32884
• fix receipt scan issues on mobile #32886
• [CP Staging] Enable KB Avoiding View + remove padding bottom #32887
• [CP Staging] fix not able to cancel selected category while creating IOU #32888
• [CP Stag] Fix redirection to confirmation page when adding a receipt #32892
• [CP Staging] Fix creating unexpected groups when creating a split from a group #32896
• Fix: Compose-Tapping on request money deep link app crashes #32916
• Fix request flow #32918
• Add missing import to unblock native staging build testing #32925
• Fix: IOU-Unable to create distance request after deleting finish waypoint, error displayed #32932
• Fix optimistic data for distance request #32943
• Not show prompt open in desktop app for magic link #32945
• Stop treating money requests as a split when going back from the confirmation step #32948
• [CP Staging] Clear plaid data when trying to enable wallet #32949

Deploy Blockers:

• [HOLD for payment 2023-12-20] [$500] Desktop - Expired magic code page for a valid code with no prior use + inability to exit the screen #32795
• [HOLD for payment 2023-12-20] [$500] Request money - Not here page appears in RHP after requesting money #32807
• [HOLD for payment 2023-12-20] [$500] Split - Participants under “Split with” list disappear after unselecting them #32808
• [HOLD for payment 2023-12-20] [$500] Web - Split Scan - Console error shows up when clicking Split on empty split action menu #32809
• [$500] Android - Split scan - Unable to select workspace as recipient when creating split scan in WS chat #32810
• IOU - User is able to select a date in the future when creating IOU request #32811
• [HOLD for payment 2023-12-20] IOU - Incorrect animation display when selecting Split bill members #32819
• [HOLD for payment 2023-12-20] [$500] IOU - Currency edit is saved when the edit is discarded in confirmation page #32826
• [HOLD for payment 2023-12-20] Split - Adding a receipt to a manual split request turns it into a scan split request #32829
• [HOLD for payment 2023-12-20] IOU - Add receipt header is missing in Add receipt page #32831
• [HOLD for payment 2023-12-20] [$500] IOU - User is redirected to participant selection page after adding a receipt #32834
• [HOLD for payment 2023-12-20] Android - IOU - Unable to capture receipt photo, the camera error displayed #32836
• [$500] [HOLD for payment 2023-12-20] IOU - Currency is reverted to the original currency after switching between tabs #32838
• [$500] Task – There is no additional subtask with assignee under the main task in a group chat. #32840
• [WAITING ON CHECKLIST] Android - Request Money - A black area appears in the receipt #32844
• [HOLD for payment 2023-12-20] IOU - An error occurs when creating a Split Bill #32852
• [HOLD for payment 2023-12-20] [$500] Split - User is redirected to LHN instead of group chat #32853
• [HOLD for payment 2023-12-20] [$500] Split - A new group is formed when splitting bill with a few members in the group #32855
• [HOLD for payment 2024-01-24] [$500] Android - Request-Wrong error message appears when tryin to choose my location for start and finish #32863
• [Paid] Android - IOU - App crashes when adding a receipt from gallery in confirmation page #32865
• [HOLD for payment 2023-12-20] [$500] Split - User can select or unselect members on comfirmation page when splitting bill from FAB #32867
• [$500] [HOLD for payment 2023-12-20] IOU - An employee cannot cancel a selected category when creating an IOU #32872
• Web - Notification - Notification does not come when user switch back to online #32881
• [HOLD for payment 2023-12-20] iOS - IOU - "Save" button does not relocate to the top when the input label is focused #32882
• [HOLD for payment 2023-12-20] [$500] Distance- Request created offline does not show TBD in many areas and unable to open distance editor #32891
• Web - Split - Scan bill split is created in one of the participants' chat instead of new group chat #32895
• [$500] Wallet-Tapping "Enable wallet",add bank account page with select Chase is displayed. #32906
• [Awaiting Checklist Completion] [$500] IOU-Unable to create distance request after deleting finish waypoint, error displayed #32908
• [HOLD for payment 2023-12-20] [$500] Compose-Tapping on request money deep link app crashes #32911
• [HOLD for payment 2024-03-07] [LOW] [P2P] [$500] IOU-Add a contact to request money and tap back button, contact added to split. #32912
• [HOLD for payment 2024-02-07] [$500] Expense - Green dot does not appear in LHN when the request is created in workspace chat #32924
• IOU-Error "hhm its not here" displayed on refreshing split bill confirmation page #32934

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.11-1 🚀

[Julesssss]

@tgolen demoted #32807 form being a blocker, and closed #32811 as expected behaviour 👍

[luacmartins]

Checking off #32819. We CPed a fix

[luacmartins]

Checking off #32808 and #32809. We're CPing fixes

[luacmartins]

Checking off #32829. We're CPing a fix

[luacmartins]

Checking off #32836. We merged a fix and are CPing it https://expensify.slack.com/archives/C07J32337/p1702331007057339

[kavimuru]

Regression is at 94%.

#32209 failing with #32812 repro in PROD checking it off
#28618 failing with #32836
#32633 failing with KI #31822 checking it off
#31481 failing with KI #32656 checking it off
#32334 failing with KI #31816 not fixed, checking it off

[luacmartins]

@Julesssss we went through as many blockers as we could, and we have a few fixes along the way:

• [CP Staging] fix: store selected currency in URL query temporarily #32851
• [CP Staging] Fix missing header #32877
• Fix amount reset #32884
• fix receipt scan issues on mobile #32886

[marcaaron]

Fix here for #32882 needs review + CP

[shubham1206agra]

Please CP this #32888

[Julesssss]

The following 13 PRs have been resolved and cherry-picked to staging. I haven't checked these off yet as there have been a lot of regression fixes merged today. I am about to seek help testing these on build 1.4.11-16:

#32838 fixed by #32884
#32872 fixed by #32888
#32826 fixed by #32851
#32831 fixed by #32877
#32855 fixed by #32896
#32852 fixed by #32896
#32853 fixed by #32878
#32836 fixed by #32854
#32911 fixed by #32916
#32925 fixed by #32925
#32895 fixed by #32918
#32867 fixed by #32918

[puneetlath]

Confirmed #32867 is fixed.

[luacmartins]

Checking off #32934. Fixed in #32849

[luacmartins]

Checking off #32855. Fixed

[luacmartins]

Checking off #32834. Fixed by #32892

[francoisl]

Checking off 32865 and 32844, confirmed working on native Android on v1.4.11-20.

[luacmartins]

Checking off #32908. Fixed by #32932

[luacmartins]

Checking off #32924. Demoted to NAB since the prod behavior although different, is also broken.

[luacmartins]

Checking off #32882. Fixed by #32887

[luacmartins]

Checking off #32891. Fixed by #32943

[luacmartins]

Checking off #32795. Fixed by #32945

[Julesssss]

Checking off #32912, fixed by #32948

[cristipaval]

Checking off #32906, fixed by #32949

[Julesssss]

@cristipaval lets wait until its successfully CP'd and tested

[Julesssss]

Checking off these as its testing well for me

[Julesssss]

Checking off the main issue: #32794 as all of the regressions have been handled 😓

[Julesssss]

• App timing nominal
• iOS has a couple of new exceptions:
  • A) Cannot read property 'chatReportID' of null in 1.4.11-4 -- a single crash in an outdated build is not worth blocking over
  • B) EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000 -- ignoring as a one-off, also 20 releases out of date
  • C) ReferenceError: Property 'compose' doesn't exist, js engine: hermes -- I introduced this exception with a bad conflict resolution, fixed here
• Github status is good

[Julesssss]