[HOLD for payment 2023-12-20] [$500] Request money - Not here page appears in RHP after requesting money

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Open a new chat,
3. Click + > Request money.
4. Enter amount and proceed to confirmation page.
5. Click Request.
   (Might need to repeat Step 3 - 5 to see the issue).

Expected Result:

Not here page will not show up in RHP after requesting money.

Actual Result:

While RHP is closing, not here page can be seen in the RHP.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6308957_1702302215945.20231211_203033.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e13942c515d900b4
• Upwork Job ID: 1734223793696989184
• Last Price Increase: 2023-12-11
• Automatic offers:
• getusha | Reviewer | 28036036
• paultsimura | Contributor | 28036038

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll look into this.

[tgolen]

I'm going to demote this from being a deploy blocker. It doesn't effect the user in any way and the flow still works. I've applied the help wanted label to get some more eyes on this.

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e13942c515d900b4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When requesting money, the NotFound page is shown for a moment.

What is the root cause of that problem?

We have the IOURequestStepConfirmation wrapped with withFullTransactionOrNotFound:

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 348 to 363 in a16df0d

	export default compose(
	withCurrentUserPersonalDetails,
	withWritableReportOrNotFound,
	withFullTransactionOrNotFound,
	withOnyx({
	personalDetails: {
	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
	},
	}),
	// eslint-disable-next-line rulesdir/no-multiple-onyx-in-file
	withOnyx({
	policy: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${lodashGet(report, 'policyID', '0')}`,
	},
	}),
	)(IOURequestStepConfirmation);

It returns the NotFound page when the transaction is not found:

App/src/pages/iou/request/step/withFullTransactionOrNotFound.js

Lines 34 to 37 in 968f39f

	// If the transaction does not have a transactionID, then the transaction no longer exists in Onyx as a full transaction and the not-found page should be shown
	if (!transactionID) {
	return <FullPageNotFoundView shouldShow />;
	}

The transaction ID is taken from a route param, which is no longer present when navigating after the request was created. Therefore, the NotFound page is briefly displayed.

What changes do you think we should make in order to solve the problem?

We should enhance the WithFullTransactionOrNotFound (and WithWritableReportOrNotFound) wrapper by detecting whether the component is focused through nevigation (i.e. is open). And show the NotFound page only if the component is open (focused):

const isFocused = useIsFocused();

if (!transactionID) {
    return <FullPageNotFoundView shouldShow={isFocused} />;
}

Optionally, we can show FullScreenLoadingIndicator if !isFocused to handle this as another semi-faulty state:

if (!transactionID) {
    return isFocused ? <FullPageNotFoundView shouldShow /> : <FullScreenLoadingIndicator/>;
}

Result:

Screen.Recording.2023-12-11.at.16.47.30.mov

What alternative solutions did you explore? (Optional)

[tgolen]

Ah, cool. I didn't know about the isFocused hook. Looks like that would do the trick. I like using shouldShow. I don't think we want a loading indicator during those transitions.

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

Thanks. The PR is ready for review: #32849

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[paultsimura]

@Julesssss This shouldn't have been closed as it's not paid out yet, if I'm not mistaken.

[Julesssss]

Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Handle brief NotFound page on the Request Money flow #32849

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[peterdbarkerUK]

$500 to @paultsimura for Contributor, paid and thanks!

@getusha could you take a spin through the regression checklist, and then accept the offer?

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1434478894
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
• Determine if we should create a regression test for this bug. i think this bug is minor and hard to notice so No.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[getusha]

@peterdbarkerUK accepted the offer

[melvin-bot]

@tgolen, @paultsimura, @peterdbarkerUK, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tgolen]

@peterdbarkerUK Is there more to do here to complete the payments?

[peterdbarkerUK]

Nope, was just OoO.

Payments processed!