fix: Handle brief NotFound page on the Request Money flow #32849

paultsimura · 2023-12-11T18:21:41Z

Details

This fixes the NotFound page that is briefly shown on the Request Money modal show & hide.

Fixed Issues

$ #32807
PROPOSAL: #32807 (comment)

Tests

Same as QA

Offline tests

Same as QA

QA Steps

Click + (from either composer or FAB) > Request money

Verify the "Not Found" page does not show while the modal is loading

Enter the amount and proceed to the confirmation page.
Click Request

Verify the "Not Found" page does not show while the modal is hiding

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-compressed.mp4

Android: mWeb Chrome

chrome-compressed.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

safari.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-12-11T18:21:46Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2023-12-11T18:25:46Z

src/pages/iou/request/IOURequestStartPage.js

+    if (!transaction.transactionID) {
+        // The draft transaction is initialized only after the component is mounted,
+        // which will lead to briefly displaying the Not Found page without this loader.
+        return <FullScreenLoadingIndicator />;
+    }


@tgolen even though this was not in the original proposal, I've noticed that the NotFound page shows also while the modal is opening. The root cause here is different – it's caused by the draft transaction being initialized only after the component is mounted, by calling IOU.startMoneyRequest_temporaryForRefactor.
Please let me know if you think this change is not suitable here – I couldn't come up with a better fix for this case so far.

Thanks for digging into that. I think this fix is fine and I 💚 the fix here.

tgolen · 2023-12-11T18:30:26Z

src/pages/iou/request/step/withFullTransactionOrNotFound.js

-        // If the transaction does not have a transactionID, then the transaction no longer exists in Onyx as a full transaction and the not-found page should be shown
+        const isFocused = useIsFocused();
+
+        // If the transaction does not have a transactionID, then the transaction no longer exists in Onyx as a full transaction and the not-found page should be shown.


Would you mind updating this comment to explain why isFocused is part of the logic?

Done ✔️

tgolen · 2023-12-12T15:57:26Z

@getusha Are you able to get to the checklist today?

getusha · 2023-12-12T15:58:43Z

@tgolen on it, thanks.

getusha · 2023-12-12T16:02:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-12.at.7.27.33.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-12.at.7.25.09.PM.mov

iOS: Native

Screen.Recording.2023-12-12.at.7.30.40.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-12.at.7.20.58.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-12.at.7.17.03.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-12.at.7.35.50.PM.mov

getusha

lgtm as well and works well. @tgolen all yours

OSBotify · 2023-12-12T17:19:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…t-found fix: Handle brief NotFound page on the Request Money flow (cherry picked from commit c21f455)

luacmartins · 2023-12-12T19:11:19Z

Tested in staging. This is a pass.

OSBotify · 2023-12-13T11:10:10Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Handle brief NotFound page on the Request Money flow

d3f4c18

paultsimura requested a review from a team as a code owner December 11, 2023 18:21

melvin-bot bot requested review from getusha and removed request for a team December 11, 2023 18:21

paultsimura commented Dec 11, 2023

View reviewed changes

paultsimura mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-20] [$500] Request money - Not here page appears in RHP after requesting money #32807

Closed

6 tasks

tgolen requested changes Dec 11, 2023

View reviewed changes

Add comment explaining isFocused usage

c78c451

paultsimura requested a review from tgolen December 11, 2023 18:42

tgolen approved these changes Dec 11, 2023

View reviewed changes

luacmartins approved these changes Dec 11, 2023

View reviewed changes

getusha approved these changes Dec 12, 2023

View reviewed changes

melvin-bot bot requested a review from tgolen December 12, 2023 17:12

luacmartins merged commit c21f455 into Expensify:main Dec 12, 2023
15 of 18 checks passed

This was referenced Dec 12, 2023

IOU-Error "hhm its not here" displayed on refreshing split bill confirmation page #32934

Closed

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

OSBotify pushed a commit that referenced this pull request Dec 12, 2023

Merge pull request #32849 from paultsimura/fix/32807-request-money-no…

09bde54

…t-found fix: Handle brief NotFound page on the Request Money flow (cherry picked from commit c21f455)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Handle brief NotFound page on the Request Money flow #32849

fix: Handle brief NotFound page on the Request Money flow #32849

paultsimura commented Dec 11, 2023

melvin-bot bot commented Dec 11, 2023

paultsimura Dec 11, 2023 •

edited

Loading

tgolen Dec 11, 2023

tgolen Dec 11, 2023

paultsimura Dec 11, 2023

tgolen commented Dec 12, 2023

getusha commented Dec 12, 2023

getusha commented Dec 12, 2023 •

edited

Loading

getusha left a comment

OSBotify commented Dec 12, 2023

luacmartins commented Dec 12, 2023

OSBotify commented Dec 13, 2023

fix: Handle brief NotFound page on the Request Money flow #32849

fix: Handle brief NotFound page on the Request Money flow #32849

Conversation

paultsimura commented Dec 11, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 11, 2023

paultsimura Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

tgolen Dec 11, 2023

Choose a reason for hiding this comment

tgolen Dec 11, 2023

Choose a reason for hiding this comment

paultsimura Dec 11, 2023

Choose a reason for hiding this comment

tgolen commented Dec 12, 2023

getusha commented Dec 12, 2023

getusha commented Dec 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2023

luacmartins commented Dec 12, 2023

OSBotify commented Dec 13, 2023

paultsimura Dec 11, 2023 •

edited

Loading

getusha commented Dec 12, 2023 •

edited

Loading